Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexed modulators incorrectly interact with some parts of UI state #5380

Closed
VincyZed opened this issue Nov 13, 2021 · 2 comments · Fixed by #5423
Closed

Indexed modulators incorrectly interact with some parts of UI state #5380

VincyZed opened this issue Nov 13, 2021 · 2 comments · Fixed by #5423
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Milestone
Surge XT 1.0

Comments

@VincyZed
Copy link
Collaborator

VincyZed commented Nov 13, 2021 •
edited
Loading

Here's how to reproduce :

  1. Open a fresh instance of Surge XT.

  2. Go straight to the Random or Alternate modulator - click on the hamburger menu and switch to another random type (or mouse wheel over it)

  3. Engage routing mode. You will see the first issue here: you won't be able to modulate parameters of LFO-1 (just below) when normally you should.
    image

  4. Apply some modulation to scene control(s).

  5. Disengage routing mode. You will see the second issue: the modulation source will not have the bright border indicating that it is active.
    image

You may try multiple times to do these steps if it doesn't work the first time.
@VincyZed VincyZed added the Bug Report Item submitted using the Bug Report template label Nov 13, 2021
@VincyZed VincyZed added this to the Surge XT 1.0 milestone Nov 13, 2021
@baconpaul
Copy link
Collaborator

great bug report
the reverse hovers (slider turns source green) are also broken

@baconpaul
Copy link
Collaborator

In fact, the reverse hovers are generally just not index aware. Make a formula and map 1 and 2 to some features of another LFO. The 1 hovers the formula even if it is set to 2

@baconpaul baconpaul changed the title Random and Alternate modulation routing visual bug Indexed modulators incorrectly interact with some parts of UI state Nov 13, 2021
@mkruselj mkruselj added the UI Issues related to UI look&feel label Nov 13, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Nov 17, 2021
@baconpaul
Correct a Slider State which interacted with Index
c127d3b 
Slider Modulatable State didnt' survive modsource index
changes properly. Clean it up to restore working hovers etc

Closes surge-synthesizer#5380
@baconpaul baconpaul mentioned this issue Nov 17, 2021
Merged
baconpaul added a commit that referenced this issue Nov 17, 2021
@baconpaul
Correct a Slider State which interacted with Index (#5423)
ade3319 
Slider Modulatable State didnt' survive modsource index
changes properly. Clean it up to restore working hovers etc

Closes #5380
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Correct a Slider State which interacted with Index baconpaul/surge
3 participants
@mkruselj @baconpaul @VincyZed