Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PatchSelector Comment Field Hovers after Menu Open #5377

Closed
baconpaul opened this issue Nov 13, 2021 · 0 comments · Fixed by #5382
Closed

PatchSelector Comment Field Hovers after Menu Open #5377

baconpaul opened this issue Nov 13, 2021 · 0 comments · Fixed by #5382
Labels
UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

@VincyZed reports

I also just noticed the comment box when hovering over the patch browser, clever!
Oh just noticed a small bug about it though, when left-clicking to open the patch browser and then navigating a bit in it, if you close it by clicking elsewhere, the comment popup will be opened until you mouse over it again
Basically it thinks your pointer is still over the patch browser

BP says: when you open the patch menu end the comment hover timer thingy.
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Nov 13, 2021
@baconpaul baconpaul added the UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. label Nov 13, 2021
@baconpaul baconpaul changed the title Comment with Patch Selector PatchSelector Comment Field Hovers after Menu Open Nov 13, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Nov 13, 2021
@baconpaul
Small Fixes to Audio Path and Patch Comment
8cfce74 
1. Patch Comment dismisses and timer cancels on menu show in
   patch selector. Closes surge-synthesizer#5377
2. With audio engine off, make loadByPath mechanism work just
   like loadById does. Closes surge-synthesizer#5381
3. Add a comment to the reich patch
@baconpaul baconpaul mentioned this issue Nov 13, 2021
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Nov 13, 2021
@baconpaul
Small Fixes to Audio Path and Patch Comment
d964509 
1. Patch Comment dismisses and timer cancels on menu show in
   patch selector. Closes surge-synthesizer#5377
2. With audio engine off, make loadByPath mechanism work just
   like loadById does. Closes surge-synthesizer#5381
3. Add a comment to the reich patch
4. Make the MiniEdit also skip recursion in the new deletion sweep
baconpaul added a commit to baconpaul/surge that referenced this issue Nov 13, 2021
@baconpaul
Small Fixes to Audio Path and Patch Comment
5ebf6a1 
1. Patch Comment dismisses and timer cancels on menu show in
   patch selector. Closes surge-synthesizer#5377
2. With audio engine off, make loadByPath mechanism work just
   like loadById does. Closes surge-synthesizer#5381
3. Add a comment to the reich patch
4. Make the MiniEdit also skip recursion in the new deletion sweep
5. Add SampleRate to the About screen
baconpaul added a commit that referenced this issue Nov 13, 2021
@baconpaul
Small Fixes to Audio Path and Patch Comment (#5382)
9f6c679 
1. Patch Comment dismisses and timer cancels on menu show in
   patch selector. Closes #5377
2. With audio engine off, make loadByPath mechanism work just
   like loadById does. Closes #5381
3. Add a comment to the reich patch
4. Make the MiniEdit also skip recursion in the new deletion sweep
5. Add SampleRate to the About screen
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Small Fixes to Audio Path and Patch Comment baconpaul/surge
1 participant
@baconpaul