Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JUCE sample rate setting is late #5353

Closed
baconpaul opened this issue Nov 7, 2021 · 0 comments · Fixed by #5358
Closed

JUCE sample rate setting is late #5353

baconpaul opened this issue Nov 7, 2021 · 0 comments · Fixed by #5358
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

so reading the code
the sample rate is set
in AirWindowsEffect::setupSubFx
48000 is the sample rate you get if nothing has been set
so i wonder if there's an out of order create
if you change the airwin type to galactic and back do you get the right sample rate?
if so that's the bug
damnit yes that's exactly it and it is a real bug
SurgeXT Standalone

  • Version : 0.9.main.ec35143f with JUCE 60102
  • Build Info : 2021-11-07 14:03:56 using AppleClang-13.0.0.13000029
  • Data : "/Users/paul/dev/music/surge-xt/resources/data"
  • User Data : "/Users/paul/Documents/Surge XT"
    AirWin create with 48000
    Setting sample rate to 44100
    AirWin create with 44100

when we restore the patch the sample rate hasn't been established yet in juce through prepareToPlay
so we restore at the default of 48khz
if you swao the type it will recreate but we need to fix that
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Nov 7, 2021
@mkruselj mkruselj added the Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE label Nov 7, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Nov 7, 2021
@mkruselj mkruselj changed the title juce sample rate setting is late JUCE sample rate setting is late Nov 9, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Nov 10, 2021
@baconpaul
Notify FX on sample rate changes
0694cb8 
This allows FX which cache the sample rate for various
reasons (notably Airwindows to avoid a link cycle) to
get updated correctly. This is especially important in
the standalone startup path.

Closes surge-synthesizer#5353
@baconpaul baconpaul mentioned this issue Nov 10, 2021
Merged
baconpaul added a commit that referenced this issue Nov 10, 2021
@baconpaul
Notify FX on sample rate changes (#5358)
9533018 
This allows FX which cache the sample rate for various
reasons (notably Airwindows to avoid a link cycle) to
get updated correctly. This is especially important in
the standalone startup path.

Closes #5353
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Notify FX on sample rate changes baconpaul/surge
2 participants
@mkruselj @baconpaul