Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A moved FX leaves behind modulations #5348

Closed
j5v opened this issue Nov 4, 2021 · 5 comments · Fixed by #5364
Closed

A moved FX leaves behind modulations #5348

j5v opened this issue Nov 4, 2021 · 5 comments · Fixed by #5364
Labels
Bug Report Item submitted using the Bug Report template Effects
Milestone
Surge XT 1.0

Comments

@j5v
Copy link
Contributor

j5v commented Nov 4, 2021

Bug Description:
Modulations onto FX parameters are not moved when the FX is moved.

Surge Version
Version: Surge XT 0.9.nightly.3988237
Build: 2021-11-03 @ 15:09:11 on 'WIN-EH9TN3FK03B/pipeline' with 'MSVC-19.16.27045.0' using JUCE 60102
System: Windows 64-bit VST3 on Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Host: Cakewalk by Bandlab

Reproduction Steps:
Steps to reproduce the behavior:

  1. Add an FX to a patch
  2. Modulate one of the FX parameters.
  3. Move the FX. The modulation disappears.
  4. Move the FX to the original FX slot. The modulation re-appears

Expected Behavior:
The modulation should remain with the FX as it moves.

Screenshots:
.

Computer Information (please complete the following information):
.

Additional Information:
If fixing this bug, also look at the more complicated variant, where the user swaps FX slots (much more fun!).
@j5v j5v added the Bug Report Item submitted using the Bug Report template label Nov 4, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Nov 5, 2021
@baconpaul
Copy link
Collaborator

Oh good eyes

@baconpaul
Copy link
Collaborator

OK yeah this is "all sorts of broken". The code tries to do stuff but it just doesn't work properly.

This is a good one for regtests!

@baconpaul
Copy link
Collaborator

Quick poll

We have three gestures, swap, copy, and move

swap and move are obvious

copy should copy modulation also?

I think 'yes' but want to be sure.

baconpaul added a commit to baconpaul/surge that referenced this issue Nov 11, 2021
@baconpaul
Fix couple of FX Move things
ba06945 
1. With index modulators, we had an index error!
2. Clear the target and source appropriately
3. Add a reasonable regtest to make sure I don't break it in the future

Closes surge-synthesizer#5348
@baconpaul baconpaul mentioned this issue Nov 11, 2021
Merged
baconpaul added a commit that referenced this issue Nov 11, 2021
@baconpaul
Fix couple of FX Move things (#5364)
72d04ab 
1. With index modulators, we had an index error!
2. Clear the target and source appropriately
3. Add a reasonable regtest to make sure I don't break it in the future

Closes #5348
@mkruselj
Copy link
Collaborator

Yeah I think it should. Or maybe with a modifier?

@baconpaul
Copy link
Collaborator

I made it so it does :)

@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Effects
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Fix couple of FX Move things baconpaul/surge
3 participants
@mkruselj @j5v @baconpaul