-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When using cursor left & right or category+/-, if you end up in an empty category (like a parent) nothing happens #533
Comments
This "transcend the boundary" bug does not appear when in Factory |
And the same issue will occur when at "wavetables" or "last userpreset category" and pressing right once = doesn't go to Bass. Press right another time = does go to bass. |
Another addition: When you are in the same place (Zoozither) and press Category Same twice happens when you press Category |
The problem here is pressing "+" into a category which has children. So if your categories look like
(which they do) but nested contains no patches you end up with this behaviour The fix is to skip patch-free categories in +/- That's a bit tricky - won't do it right now i don't think thanks @esaruoho good catch! |
Nested folders meant parents existed which were valid categories with no patches. Navigating to them with category +/- gave a very counterintuitive result of not doing anything when you arrived at them. Fix that by accumulating the number of patches in each category and only doing incrementCategory into a category with patches. Closes surge-synthesizer#533
Nested folders meant parents existed which were valid categories with no patches. Navigating to them with category +/- gave a very counterintuitive result of not doing anything when you arrived at them. Fix that by accumulating the number of patches in each category and only doing incrementCategory into a category with patches. Closes #533
Nested folders meant parents existed which were valid categories with no patches. Navigating to them with category +/- gave a very counterintuitive result of not doing anything when you arrived at them. Fix that by accumulating the number of patches in each category and only doing incrementCategory into a category with patches. Closes surge-synthesizer#533 Former-commit-id: 0e8d2cbdb2722d30e448cfd53529482d59b0bc04 [formerly c81f446] Former-commit-id: 7442cf4e93f1f637173899b2e46d444c157a776c Former-commit-id: a34ec32faea3d4e76faee430bc3400e168a11c36
I opened a ticket about this ages ago, because it occurred with the +/-, but now i got it replicated with cursor keys left and right.
Steps to replicate:
ZooZither 3 - zzsurge_Brainstem
( this is the last "factory" preset before the user presets start )Expected result:
You are now in
3rdparty/Analog Monsters - BRASSY
. (the first user preset category preset)Current result:
Nothing happens.
Press Right cursor key again. You are now in
3rdparty/Analog Monsters - BRASSY
.Now press left cursor once.
Expected result:
You are in
ZooZither 3 - zzsurge_Brainstem
. (the last library preset category preset)Current result:
Nothing happens.
Press Right cursor again -and you are now in
ZooZither 3 - zzsurge_Brainstem
The text was updated successfully, but these errors were encountered: