Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using cursor left & right or category+/-, if you end up in an empty category (like a parent) nothing happens #533

Closed
esaruoho opened this issue Feb 7, 2019 · 5 comments

Comments

@esaruoho
Copy link
Collaborator

esaruoho commented Feb 7, 2019

I opened a ticket about this ages ago, because it occurred with the +/-, but now i got it replicated with cursor keys left and right.

Steps to replicate:

  1. Go to ZooZither 3 - zzsurge_Brainstem ( this is the last "factory" preset before the user presets start )
  2. Press the Right cursor key.

Expected result:
You are now in 3rdparty/Analog Monsters - BRASSY. (the first user preset category preset)

Current result:
Nothing happens.
Press Right cursor key again. You are now in 3rdparty/Analog Monsters - BRASSY.

Now press left cursor once.
Expected result:
You are in ZooZither 3 - zzsurge_Brainstem. (the last library preset category preset)

Current result:
Nothing happens.
Press Right cursor again -and you are now in ZooZither 3 - zzsurge_Brainstem

@esaruoho
Copy link
Collaborator Author

esaruoho commented Feb 7, 2019

here's the culprit "line".
fullscreen_07_02_2019__18_45

@esaruoho
Copy link
Collaborator Author

esaruoho commented Feb 7, 2019

This "transcend the boundary" bug does not appear when in Factory Wind category and getting to Argitoth.. Only when crossing from factory3rdparty to "userpresets"

@esaruoho
Copy link
Collaborator Author

esaruoho commented Feb 7, 2019

And the same issue will occur when at "wavetables" or "last userpreset category" and pressing right once = doesn't go to Bass. Press right another time = does go to bass.

@esaruoho esaruoho changed the title When using cursor left & right, and "crossing the boundary" between category listings, need to press right _twice_ instead of _once_ When using cursor left & right, and "crossing the boundary" between user presets and library presets, need to press right _twice_ instead of _once_ Feb 7, 2019
@esaruoho esaruoho changed the title When using cursor left & right, and "crossing the boundary" between user presets and library presets, need to press right _twice_ instead of _once_ When using cursor left & right or category+/-, and "crossing the boundary" between user presets and library presets, need to press right _twice_ instead of _once_ Feb 7, 2019
@esaruoho
Copy link
Collaborator Author

esaruoho commented Feb 7, 2019

Another addition: When you are in the same place (Zoozither) and press Category + - nothing happens. Press Category + again, and you will be in the first user-preset folder's first preset.

Same twice happens when you press Category - - need to press it twice to transcend the boundary.

@baconpaul baconpaul changed the title When using cursor left & right or category+/-, and "crossing the boundary" between user presets and library presets, need to press right _twice_ instead of _once_ When using cursor left & right or category+/-, if you end up in an empty category (like a parent) nothing happens Feb 7, 2019
@baconpaul
Copy link
Collaborator

baconpaul commented Feb 7, 2019

The problem here is pressing "+" into a category which has children. So if your categories look like

zither
nested
nested/foo
nested/bar

(which they do) but nested contains no patches you end up with this behaviour

The fix is to skip patch-free categories in +/-

That's a bit tricky - won't do it right now i don't think

thanks @esaruoho good catch!

baconpaul added a commit to baconpaul/surge that referenced this issue Feb 7, 2019
Nested folders meant parents existed which were valid categories
with no patches. Navigating to them with category +/- gave a very
counterintuitive result of not doing anything when you
arrived at them.  Fix that by accumulating the number of patches
in each category and only doing incrementCategory into a category
with patches.

Closes surge-synthesizer#533
baconpaul added a commit that referenced this issue Feb 8, 2019
Nested folders meant parents existed which were valid categories
with no patches. Navigating to them with category +/- gave a very
counterintuitive result of not doing anything when you
arrived at them.  Fix that by accumulating the number of patches
in each category and only doing incrementCategory into a category
with patches.

Closes #533
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 10, 2019
Nested folders meant parents existed which were valid categories
with no patches. Navigating to them with category +/- gave a very
counterintuitive result of not doing anything when you
arrived at them.  Fix that by accumulating the number of patches
in each category and only doing incrementCategory into a category
with patches.

Closes surge-synthesizer#533

Former-commit-id: 0e8d2cbdb2722d30e448cfd53529482d59b0bc04 [formerly c81f446]
Former-commit-id: 7442cf4e93f1f637173899b2e46d444c157a776c
Former-commit-id: a34ec32faea3d4e76faee430bc3400e168a11c36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants