Octave-per-channel mode should use the Scala file's "octave" rather than a hard-coded 1200 cents

[battaglia01]

Surge recently added an octave-per-channel mode which was quite useful. However, the "octave" that it transposes by seems to be hard-coded to 1200 cents, whereas it really should be the "octave" from the scala file (e.g. the last line of the scala file). So for instance, if you're playing in the triple-BP scale (39-ED3), the next channel should be a tritave off rather than an octave. Or if you're using a scala file with a slightly stretched-octave scale (e.g. 14-ED2 but with a 1214 cent octave, basically the DTMF touch tone phone system), then it should be that 1214 cent interval instead.

Maybe it'd be useful if the user could just choose the amount of channel offset manually, or something like that, but I'd at least be happy enough if it just used the one from the Scala file.

Surge Version

• Version: This is in the Surge 0.9 nightly e2acce5 build.
• Plugin Type: Standalone
• Bitness: 64-bit

Reproduction Steps:
Steps to reproduce the behavior: load up 39-ED3, you'll see the channels are moving by 1200 cent "octaves" rather than tritaves

Expected Behavior:
It moves by the Scala "formal octave" instead (e.g. the last line of the Scala file)

[baconpaul]

Oh yeah you are totally correct.
@cgibbard and I have been chatting about a fix to portamento also so perhaps we can get both and add a test when we do.
thanks for raising this.

[baconpaul]

PR #5274 fixes this. Should be in a nightly later today. This issue will close when I merge but usually takes 30-60 minutes for new nightly to arrive after that, sometimes a tad longer

Thanks for reporting!