Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch DB / TypeAhead work for XT 1.0 #5253

Closed
2 tasks done
baconpaul opened this issue Oct 14, 2021 · 2 comments · Fixed by #5431 or #5438
Closed
2 tasks done

Patch DB / TypeAhead work for XT 1.0 #5253

baconpaul opened this issue Oct 14, 2021 · 2 comments · Fixed by #5431 or #5438
Labels
Patch Browser WIP Issues that are an ongoing work in progress
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Oct 14, 2021 •
edited
Loading

  • Schema Upgrade broken with new scheme (requires double run)
  • Author and Category searches are in the grammar but not the SQL
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Oct 14, 2021
@baconpaul baconpaul mentioned this issue Oct 14, 2021
Closed
2 tasks
@surge-synthesizer surge-synthesizer deleted a comment from baconpaul Oct 14, 2021
@surge-synthesizer surge-synthesizer deleted a comment from baconpaul Oct 14, 2021
@mkruselj mkruselj added the WIP Issues that are an ongoing work in progress label Oct 15, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Oct 15, 2021
@baconpaul
PatchDB Progress
3f2ae8f 
1. Disable Patch Browser
2. Update the patchdb when you store a patch, but at the cost
   of the schema upgrade mechanism being broken.
3. Show total patch count in UI
4. Cleanup cout
5. Make click to select work

Addresses surge-synthesizer#5253
@baconpaul baconpaul mentioned this issue Oct 15, 2021
Merged
baconpaul added a commit that referenced this issue Oct 15, 2021
@baconpaul
PatchDB Progress (#5256)
0e1b013 
1. Disable Patch Browser
2. Update the patchdb when you store a patch, but at the cost
   of the schema upgrade mechanism being broken.
3. Show total patch count in UI
4. Cleanup cout
5. Make click to select work

Addresses #5253
baconpaul added a commit to baconpaul/surge that referenced this issue Nov 19, 2021
@baconpaul
Last fixes for the patch db
b4e1e6c 
1. Schema Migration works without locking and crashing again
2. AUTHOR= and CATEGORY= searches

Closes surge-synthesizer#5253
@baconpaul baconpaul mentioned this issue Nov 19, 2021
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Nov 19, 2021
@baconpaul
Last fixes for the patch db
136d79d 
1. Schema Migration works without locking and crashing again
2. AUTHOR= and CATEGORY= searches

Closes surge-synthesizer#5253
baconpaul added a commit that referenced this issue Nov 19, 2021
@baconpaul
Last fixes for the patch db (#5431)
a8fcc44 
1. Schema Migration works without locking and crashing again
2. AUTHOR= and CATEGORY= searches

Closes #5253
@mkruselj
Copy link
Collaborator

mkruselj commented Nov 20, 2021 •
edited by baconpaul
Loading

@baconpaul There's still two semi-related issues left regarding patch typeahead, more visual though:

  • Typeahead border is not drawn at all (it's set to black in the skin):

image

I guess also:

  • Lines need to be integerized? (See between Banter and Bitten patches)

  • At least on Windows, there's that prickly leftover/cutout at the bottom in the magnifier and heart icon SVGs (I see it on 125, 150 and 175 zoom here):

image
image

@mkruselj mkruselj reopened this Nov 20, 2021
@baconpaul
Copy link
Collaborator Author

Thanks!

baconpaul added a commit to baconpaul/surge that referenced this issue Nov 21, 2021
@baconpaul
Fix some rendering edge cases with typeahead
1bd4876 
Closes surge-synthesizer#5253
@baconpaul baconpaul mentioned this issue Nov 21, 2021
Merged
baconpaul added a commit that referenced this issue Nov 21, 2021
@baconpaul
Fix some rendering edge cases with typeahead (#5438)
1543188 
Closes #5253
baconpaul added a commit to baconpaul/surge that referenced this issue Nov 27, 2021
@baconpaul
Address a few modlist issues
82d87fb 
Show LFO targets with their name (e.g A ENV-3 Rate)
Flatten/Up-level the target menu a bit to be a bit more symmetric with
source

Addresses surge-synthesizer#5253
@baconpaul baconpaul mentioned this issue Nov 27, 2021
Merged
baconpaul added a commit that referenced this issue Nov 27, 2021
@baconpaul
Address a few modlist issues (#5516)
f4223c1 
Show LFO targets with their name (e.g A ENV-3 Rate)
Flatten/Up-level the target menu a bit to be a bit more symmetric with
source

Addresses #5253
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Patch Browser WIP Issues that are an ongoing work in progress
Projects
None yet
Milestone
Surge XT 1.0
2 participants
@mkruselj @baconpaul