Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay tearout topics #5247

Closed
5 of 6 tasks
mkruselj opened this issue Oct 13, 2021 · 1 comment · Fixed by #5283
Closed
5 of 6 tasks

Overlay tearout topics #5247

mkruselj opened this issue Oct 13, 2021 · 1 comment · Fixed by #5283
Labels
Bug Report Item submitted using the Bug Report template Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.0

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Oct 13, 2021 •
edited by baconpaul
Loading

  • Initial tearout seems to position the window at (0, 0) of current display. kinda think it should center it on the current display
  • Tearing out a MSEG then changing to new LFO and setting it to MSEG restores the tearout back into Surge. I'd expect the tearout to stay torn out
  • Moving overlays seems quite sensitive to mouse. it seems like the window moves by more pixels than what I'm dragging [This one is because the mouse is accelerated by zoom in the drag handler. Tricky]
  • There's a pink line at the bottom of MSEG tearout - I think I know why though
  • Kinda think tearouts should also remember their position. rather than going back to (0, 0) every time you tear them out again after closing them back in
  • open mseg; tear out; swap skins; redock

(BaconPaul updated to checklist Oct 20)
@mkruselj mkruselj added Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Bug Report Item submitted using the Bug Report template labels Oct 13, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Oct 13, 2021
@baconpaul
Copy link
Collaborator

open mseg; tear out; swap skins; it re-docks.

baconpaul added a commit to baconpaul/surge that referenced this issue Oct 21, 2021
@baconpaul
Fix TearOut objections
673a527 
Closes surge-synthesizer#5247

- Center initial position
- Handle close and reskin and swap type closes
- Pink line in mseg gone
- Mouse drag at correct speed
- Positions remember as defaults keys
@baconpaul baconpaul mentioned this issue Oct 21, 2021
Merged
baconpaul added a commit that referenced this issue Oct 21, 2021
@baconpaul
Fix TearOut objections (#5283)
dd5e129 
Closes #5247

- Center initial position
- Handle close and reskin and swap type closes
- Pink line in mseg gone
- Mouse drag at correct speed
- Positions remember as defaults keys
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Fix TearOut objections baconpaul/surge
2 participants
@mkruselj @baconpaul