Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be a bit louder or more defensive about failed cross luajit builds on mac #5242

Closed
DrEntropy opened this issue Oct 13, 2021 · 2 comments · Fixed by #5255
Closed

Be a bit louder or more defensive about failed cross luajit builds on mac #5242

DrEntropy opened this issue Oct 13, 2021 · 2 comments · Fixed by #5255
Labels
Bug Report Item submitted using the Bug Report template Infrastructure Issues related to repository, CI/CD, installers, etc.
Milestone
Surge XT 1.0

Comments

@DrEntropy
Copy link

DrEntropy commented Oct 13, 2021 •
edited
Loading

Following the instructions on the readme fails with :
No rule to make target libs/LuaJitLib/luajit/bin/libluajit.a', needed by src/surge-xt/surge-xt_artefacts/Release/Standalone/Surge XT.app/Contents/MacOS/Surge XT'".

The reason is that the lipo at the end of libs/LuaJitLib/build-fat-luajit.sh requires both builds fo the library (arm64 and x86_64) but the arm64 build is not working with X Code 13.

Work around is to copy the libluajit.a from x86_64 to the bin directory.

Suggested fix (which is beyond my meager Bash skills) is copy the working version if only one is created and skip the lipo.
@DrEntropy DrEntropy added the Bug Report Item submitted using the Bug Report template label Oct 13, 2021
@mkruselj mkruselj added the Infrastructure Issues related to repository, CI/CD, installers, etc. label Oct 13, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Oct 13, 2021
@DrEntropy
Copy link
Author

After updating the xcode command line tools (through the dmg on Apple Developer site) and doing a full clean rebuild, this problem did not occur and both arch's were built.

@baconpaul
Copy link
Collaborator

Cool. At least the error should be better thoigh or we should be defensive! I’ll patch up the script one dat

@baconpaul baconpaul changed the title Clean build fails on Mac Os with XCode 13 Be a bit louder or more defensive about failed cross luajit builds on mac Oct 14, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Oct 14, 2021
@baconpaul
Fail more loudly if the LuaJUT arm build fails
2772b1d 
Closes surge-synthesizer#5242
@baconpaul baconpaul mentioned this issue Oct 14, 2021
Merged
baconpaul added a commit that referenced this issue Oct 14, 2021
@baconpaul
Fail more loudly if the LuaJUT arm build fails (#5255)
be62d63 
Closes #5242
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Infrastructure Issues related to repository, CI/CD, installers, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Fail more loudly if the LuaJUT arm build fails baconpaul/surge
3 participants
@mkruselj @DrEntropy @baconpaul