Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esc key and overlays #5221

Closed
mkruselj opened this issue Oct 7, 2021 · 2 comments · Fixed by #5235
Closed

Esc key and overlays #5221

mkruselj opened this issue Oct 7, 2021 · 2 comments · Fixed by #5235
Labels
Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Oct 7, 2021

Escape currently does close the typein and miniedit overlays, but it does nothing to other overlays whatsoever. So here's the breakdown:

  • Esc should close any opened overlay
  • If we have multiple overlays opened, it should close them one by one in order of their opening, rather than all at once
  • If overlay is torn out, Esc closes it only if it has keyboard focus. If main Surge window has keyboard focus, it does nothing to torn out overlays

Of course, this should only work if we have Workflow>Use keyboard shortcuts option enabled! Or not? Discuss!

@mkruselj mkruselj added Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Oct 7, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Oct 7, 2021
@baconpaul
Copy link
Collaborator

I'm still not convinced escape key closing the formula and tuning overlay is what we want but if the components which use escape in there eat it it will be fine - will give it a whirl when we get to this.

@mkruselj
Copy link
Collaborator Author

mkruselj commented Oct 7, 2021

To me if I use Esc to close one overlay, I kinda want to have it for any other too. Formula editor is no different from MSEG editor to me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants