Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LFOs are able to modulate Send FX 3 and 4 Levels #5183

Closed
ztnl opened this issue Sep 30, 2021 · 4 comments · Fixed by #5184
Closed

LFOs are able to modulate Send FX 3 and 4 Levels #5183

ztnl opened this issue Sep 30, 2021 · 4 comments · Fixed by #5184
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.

Comments

@ztnl
Copy link

ztnl commented Sep 30, 2021 •
edited
Loading

Version: Surge XT 0.9.nightly.73d1544
Build: 2021-09-30 @ 19:56:44 on 'fv-az325-205/pipeline' with 'MSVC-19.16.27045.0' using JUCE 60101
System: Windows 64-bit VST3 on Intel(R) Core(TM) i7
Host: Reaper

It appears that LFOs are able to modulate both Send FX 3 and 4 Levels.
@ztnl ztnl added the Bug Report Item submitted using the Bug Report template label Sep 30, 2021
@mkruselj
Copy link
Collaborator

Note: this is only a visual niggle. Voice LFOs actually don't end up modulating the send levels. It just appears as if they can, by mistake.

@mkruselj mkruselj added UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Sep 30, 2021
@ztnl
Copy link
Author

ztnl commented Sep 30, 2021

Yes, merely appears as if they can be assigned.

@baconpaul
Copy link
Collaborator

Screen Shot 2021-09-30 at 7 00 46 PM

the lack of a [2] and [3] there is the bug

@baconpaul
Copy link
Collaborator

that's in SurgePatch.cpp

mkruselj added a commit to mkruselj/surge that referenced this issue Sep 30, 2021
@mkruselj
Fix send levels 3/4 appearing to be voice modulatable
d8f59d9 
Closes surge-synthesizer#5183
@mkruselj mkruselj mentioned this issue Sep 30, 2021
Merged
baconpaul pushed a commit that referenced this issue Sep 30, 2021
@mkruselj
Fix send levels 3/4 appearing to be voice modulatable (#5184)
6ff5014 
Closes #5183
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix send levels 3/4 appearing to be voice modulatable mkruselj/surge
3 participants
@mkruselj @baconpaul @ztnl