Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLFO highlights don't follow scene #5180

Closed
baconpaul opened this issue Sep 30, 2021 · 0 comments · Fixed by #5207
Closed

SLFO highlights don't follow scene #5180

baconpaul opened this issue Sep 30, 2021 · 0 comments · Fixed by #5207
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

Init Saw
Pull in an FX
SLFO1 A -> FX param A
Flip to scene B
SLFO1 A still paints "light" (as if it is modulating something) but RMB doesn't work
So this is UI state only.
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Sep 30, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Sep 30, 2021
@mkruselj mkruselj added the UI Issues related to UI look&feel label Sep 30, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Oct 5, 2021
@baconpaul
Fix a collection of scene mod small problems
6e9ba23 
There were a collection of problems in the new UI along with
the cross-scene stuff mostly involving mistakes around whether
a modulator was cross-scene or not. So

1. Make sure to always assigne macros and other non-split sources
   from an artificial scene 0
2. When iterating to show menus and clear, make sure you show
   all the targets for non-split sources
3. Read appropriate scene split state when activating items,
   which means an SLFO -> global in scene A didn't stay 'lit' in
   scene b

Closes surge-synthesizer#5180
Closes surge-synthesizer#5191
@baconpaul baconpaul mentioned this issue Oct 5, 2021
Merged
baconpaul added a commit that referenced this issue Oct 5, 2021
@baconpaul
Fix a collection of scene mod small problems (#5207)
74182de 
There were a collection of problems in the new UI along with
the cross-scene stuff mostly involving mistakes around whether
a modulator was cross-scene or not. So

1. Make sure to always assigne macros and other non-split sources
   from an artificial scene 0
2. When iterating to show menus and clear, make sure you show
   all the targets for non-split sources
3. Read appropriate scene split state when activating items,
   which means an SLFO -> global in scene A didn't stay 'lit' in
   scene b

Closes #5180
Closes #5191
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UI Issues related to UI look&feel
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Fix a collection of scene mod small problems baconpaul/surge
2 participants
@mkruselj @baconpaul