Linux Drawing Errors #513
Comments
baconpaul
added
UI
baconpaul
changed the title
|
Another CHSwitch one. This time when you pick "random" (which basically moves the bitmap to the last selected and crops) it blanks out the area above. This makes me think that the drawing crop rectangles in CBitmap::draw are not being properly respected but there could be other causes. |
|
Using the modulators basically blows away the UI. This is what happens when I double click on LFO2 to start modulating
|
|
Lots of other examples too. Like if you zoom after double click you end up getting much but not all of the UI restored; and if you tab (to end the modulation) then zoom you get almost all of it back. I think this is all the same problem. But it is a pretty big one. Do you guys see the same in your builds? |
|
So this ends up after all the stuff in vstgui/lib/platform/linux/cairocontext.cpp where there's a bunch of translate and clip code. The way surge works is all the graphics have all the states stacked (usually) vertically. Look at any of the bitmap assets. Then when you click it moves the pan and clips the image. So if that cairo clip code is off it could easily draw over big swaths of the UI. I don't know cairo at all. But just for whomever ends up looking. Could be something else of course! |
|
moving any slider causes the same issue. |
|
Yeah the sliders are also Trane!ated and clipped since they change color based on state |
|
I have identified what causes this problem and have a fix which is local to the surge code, even though I think somewhere vstgui is incorrect still. PR forthcoming with explanation. |
Linux drawing was mis-rendering terribly. Turns out this was because, for some reason, the inbound alpha to bitmap::draw was 255, not 1.0f, and cairocontext.cpp has a branch decision based on equality with 1.0f. This indicates there may still be a problem in vstgui (why was the 255 inbound?) but an interim fix on linux is to reset alpha=255 to alpha=1.0 which completely fixes the painting issues reported in surge-synthesizer#513 Closes surge-synthesizer#513 - Linux Painting Issues
|
OK Pull Request in. @jsakkine or @falkTX your quick scan appreciated. It is a one line change to work around a bug but want to make sure the comment is clear enough. Thank you. Gotta say, with this fix in place surge on linux feels basically like surge on windows or surge on mac. Turning to mis-positioned menu next. |
Linux drawing was mis-rendering terribly. Turns out this was because, for some reason, the inbound alpha to bitmap::draw was 255, not 1.0f, and cairocontext.cpp has a branch decision based on equality with 1.0f. This indicates there may still be a problem in vstgui (why was the 255 inbound?) but an interim fix on linux is to reset alpha=255 to alpha=1.0 which completely fixes the painting issues reported in #513 Closes #513 - Linux Painting Issues
Linux drawing was mis-rendering terribly. Turns out this was because, for some reason, the inbound alpha to bitmap::draw was 255, not 1.0f, and cairocontext.cpp has a branch decision based on equality with 1.0f. This indicates there may still be a problem in vstgui (why was the 255 inbound?) but an interim fix on linux is to reset alpha=255 to alpha=1.0 which completely fixes the painting issues reported in surge-synthesizer#513 Closes surge-synthesizer#513 - Linux Painting Issues Former-commit-id: a3887eef160a399ff54ef7824c7a7dc69b56c298 [formerly 7ba3a88] Former-commit-id: c29601ec73433bf46468733fac2c3b4432391e2b Former-commit-id: 76617bba2aed60f0c164d332c4cff97c8afd2d14
The CHSwitches are very eager to disappear. This is code in src/common/gui/CHSwitch2.cpp and .h mostly. Haven't debugged at all yet.
OS:
Host:
The text was updated successfully, but these errors were encountered: