Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursor not hidden for FEG/AEG Digital mode curve selectors #5114

Closed
mkruselj opened this issue Sep 18, 2021 · 3 comments · Fixed by #5146
Closed

Cursor not hidden for FEG/AEG Digital mode curve selectors #5114

mkruselj opened this issue Sep 18, 2021 · 3 comments · Fixed by #5146
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.0

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Sep 18, 2021 •
edited
Loading

And something weird happens with hover states - they are scrolled through three times?

envcurvesel

Maybe also add a left-right cursor icon when hovering over these controls?
@mkruselj mkruselj added UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE labels Sep 18, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Sep 18, 2021
@baconpaul
Copy link
Collaborator

3 graphics 3 hovers i bet. so it is spanning through the decay and release hover probably

@baconpaul
Copy link
Collaborator

Cursor on Hover and Hiding is really gross and not what we want. I have the code in but it is terrible
I committed code that does change-cursor-on-drag and that feels way more natural
If you disagree i left the hide stuff in there for you to try.

Also fixed that hover bug. But that was just one line :)

baconpaul added a commit to baconpaul/surge that referenced this issue Sep 23, 2021
@baconpaul
Fix a couple of MultiSwitch problems
473f55d 
1. Frame wasn't observed in hover
2. Some cursor changes when dragging make it seem more natural

Closes surge-synthesizer#5114
@baconpaul baconpaul mentioned this issue Sep 23, 2021
Merged
baconpaul added a commit that referenced this issue Sep 23, 2021
@baconpaul
Fix a couple of MultiSwitch problems (#5146)
691151c 
1. Frame wasn't observed in hover
2. Some cursor changes when dragging make it seem more natural

Closes #5114
@mkruselj
Copy link
Collaborator Author

mkruselj commented Sep 23, 2021 •
edited
Loading

Cursor on hover and hiding is exactly what we do in MSEG and on numfields already and couple other places. It's perfectly fine IMO.

@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UI Issues related to UI look&feel UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Fix a couple of MultiSwitch problems baconpaul/surge
2 participants
@mkruselj @baconpaul