Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waveshaper context menu crash #5056

Closed
mkruselj opened this issue Sep 11, 2021 · 0 comments · Fixed by #5071
Closed

Waveshaper context menu crash #5056

mkruselj opened this issue Sep 11, 2021 · 0 comments · Fixed by #5071
Labels
Before Beta If these are open we can't really call ourselves beta Bug Report Item submitted using the Bug Report template
Milestone
Surge XT 1.0

Comments

@mkruselj
Copy link
Collaborator

  1. right-click on waveshaper menu in the upper section where the WS name is
  2. enter a submenu and right-click on the entry too
  3. the menu doesn't disappear and clicking elsewhere poof crashes
@mkruselj mkruselj added Bug Report Item submitted using the Bug Report template Before Beta If these are open we can't really call ourselves beta labels Sep 11, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Sep 11, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Sep 13, 2021
@baconpaul
Fix an ownership probelm which caused WS Crash
1168afb 
WaveShaper is owned by SGE not by the SGE Skin Map, which
is fine, but it could lead to a RMB recreating a widget then
accidetntally deleting self from underneath. Fix

Closes surge-synthesizer#5056
@baconpaul baconpaul mentioned this issue Sep 13, 2021
Merged
baconpaul added a commit that referenced this issue Sep 13, 2021
@baconpaul
Fix an ownership probelm which caused WS Crash (#5071)
0313dd7 
WaveShaper is owned by SGE not by the SGE Skin Map, which
is fine, but it could lead to a RMB recreating a widget then
accidetntally deleting self from underneath. Fix

Closes #5056
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Before Beta If these are open we can't really call ourselves beta Bug Report Item submitted using the Bug Report template
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Fix an ownership probelm which caused WS Crash baconpaul/surge
1 participant
@mkruselj