Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global volume saving #5045

Closed
baconpaul opened this issue Sep 10, 2021 · 1 comment · Fixed by #5049
Closed

Global volume saving #5045

baconpaul opened this issue Sep 10, 2021 · 1 comment · Fixed by #5049
Labels
Before Beta If these are open we can't really call ourselves beta Bug Report Item submitted using the Bug Report template
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

Had information from a user that global volume save restore is inconsistently restoring values in xt after adding the feature so this is just a placeholder for me to look and not forgrt
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Sep 10, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Sep 10, 2021
@baconpaul baconpaul added the Before Beta If these are open we can't really call ourselves beta label Sep 10, 2021
@baconpaul
Copy link
Collaborator Author

trying to get a repro still

baconpaul added a commit to baconpaul/surge that referenced this issue Sep 10, 2021
@baconpaul
Fix a bug with Async Prompts
e161c17 
the Async Prompt stuff earlier htis week to get MODAL_LOOPS
on broke the non-modal Storage OkCancel. Defacto this meant
that you could never replace a patch because the OK Cancel asked you
but had already canceled.

Closes surge-synthesizer#5045, where we had thought this was a global volume saving
problem, but it was really an anything saving problem
@baconpaul baconpaul mentioned this issue Sep 10, 2021
Merged
baconpaul added a commit that referenced this issue Sep 10, 2021
@baconpaul
Fix a bug with Async Prompts (#5049)
4ee7e91 
the Async Prompt stuff earlier htis week to get MODAL_LOOPS
on broke the non-modal Storage OkCancel. Defacto this meant
that you could never replace a patch because the OK Cancel asked you
but had already canceled.

Closes #5045, where we had thought this was a global volume saving
problem, but it was really an anything saving problem
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Before Beta If these are open we can't really call ourselves beta Bug Report Item submitted using the Bug Report template
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Fix a bug with Async Prompts baconpaul/surge
1 participant
@baconpaul