Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake --install of LV2 uses the wrong file-name #5014

Closed
dromer opened this issue Sep 7, 2021 · 2 comments · Fixed by #5037
Closed

cmake --install of LV2 uses the wrong file-name #5014

dromer opened this issue Sep 7, 2021 · 2 comments · Fixed by #5037
Labels
Bug Report Item submitted using the Bug Report template Infrastructure Issues related to repository, CI/CD, installers, etc.
Milestone
Surge XT 1.0

Comments

@dromer
Copy link

dromer commented Sep 7, 2021

As discussed on the chat:

The LV2 have their spaces removed from the .so files, but the installer expects the default filenames and thus fails to find them.

Please adjust cmake so it knows what filename to expect when installing.
@dromer dromer added the Bug Report Item submitted using the Bug Report template label Sep 7, 2021
@baconpaul
Copy link
Collaborator

Basically the vst3 hack 2 lines above needs copying sigh

@baconpaul baconpaul added this to the Surge XT 1.0 milestone Sep 7, 2021
@mkruselj mkruselj added the Infrastructure Issues related to repository, CI/CD, installers, etc. label Sep 7, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Sep 9, 2021
@baconpaul
Properly install the LV2 targets
f4575bf 
Closes surge-synthesizer#5014
@baconpaul baconpaul mentioned this issue Sep 9, 2021
Merged
baconpaul added a commit that referenced this issue Sep 9, 2021
@baconpaul
Properly install the LV2 targets (#5037)
936f432 
Closes #5014
@baconpaul
Copy link
Collaborator

Just merged a fix for this.

@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Infrastructure Issues related to repository, CI/CD, installers, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Properly install the LV2 targets baconpaul/surge
3 participants
@dromer @mkruselj @baconpaul