Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tuning Bad State Related Crash #5006

Closed
baconpaul opened this issue Sep 6, 2021 · 0 comments · Fixed by #5010
Closed

Tuning Bad State Related Crash #5006

baconpaul opened this issue Sep 6, 2021 · 0 comments · Fixed by #5010
Labels
Before Beta If these are open we can't really call ourselves beta Bug Report Item submitted using the Bug Report template Tuning Non-standard tuning extensions
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

Start a surge
Load the SCL "Bohlen-Pierce.scl"
Load a KBM which doesn't map (like 31-meantone.kbm). and you get an error "can't apply mapping of size 31 to scale of length 13". fine.

Right mouse on patch browser and choose load from file

Load a patch

And you get an uncaught tuning error because the current Mapping is set incorrectly

The immediate stack is this:

Screen Shot 2021-09-06 at 6 52 27 PM

but also that KBM should be cleared when it fails to load so we don't even try

So two things to fix
@baconpaul baconpaul added Tuning Non-standard tuning extensions Bug Report Item submitted using the Bug Report template labels Sep 6, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Sep 6, 2021
@baconpaul baconpaul added the Before Beta If these are open we can't really call ourselves beta label Sep 6, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Sep 6, 2021
@baconpaul
Correctly handle TUNING errors
b685179 
A few edge cases would let uncaught exceptions into the stack.

Closes surge-synthesizer#5006
@baconpaul baconpaul mentioned this issue Sep 6, 2021
Merged
baconpaul added a commit that referenced this issue Sep 7, 2021
@baconpaul
Correctly handle TUNING errors (#5010)
3524c5e 
A few edge cases would let uncaught exceptions into the stack.

Closes #5006
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Before Beta If these are open we can't really call ourselves beta Bug Report Item submitted using the Bug Report template Tuning Non-standard tuning extensions
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Correctly handle TUNING errors baconpaul/surge
1 participant
@baconpaul