Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIDI parameter learn cannot be aborted #5004

Closed
cannero opened this issue Sep 6, 2021 · 1 comment · Fixed by #5005
Closed

MIDI parameter learn cannot be aborted #5004

cannero opened this issue Sep 6, 2021 · 1 comment · Fixed by #5005
Labels
Bug Report Item submitted using the Bug Report template MIDI MIDI support related UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.0

Comments

@cannero
Copy link
Contributor

cannero commented Sep 6, 2021

Bug Description:
MIDI parameter learn cannot be aborted in popup menu.

Surge Version

  • Version: XT 0.9
  • Plugin Type: Standalone
  • Bitness: 64-bit

Reproduction Steps:
Steps to reproduce the behavior:

  1. Right click on a control and select 'MIDI learn parameter'
  2. Right click again, 'Abort parameter MIDI learn'
  3. MIDI icon is hidden, but in popup menu MIDI learn is still active

Expected Behavior:
MIDI learn is aborted.

Computer Information (please complete the following information):

  • OS: Windows 10

Additional Information:
Abort does not set the state back to -1:

surge/src/gui/SurgeGUIEditorValueCallbacks.cpp

Line 187 in 6dc4b74

synth->learn_param = idx;

@cannero cannero added the Bug Report Item submitted using the Bug Report template label Sep 6, 2021
@mkruselj
Copy link
Collaborator

mkruselj commented Sep 6, 2021

That was a typo. Thanks for the report!

@mkruselj mkruselj added MIDI MIDI support related UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. labels Sep 6, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Sep 6, 2021
mkruselj added a commit to mkruselj/surge that referenced this issue Sep 6, 2021
@mkruselj
Revert PR surge-synthesizer#5000, abort param MIDI learn properly
5b5e798 
Closes surge-synthesizer#5004
@mkruselj mkruselj mentioned this issue Sep 6, 2021
Merged
mkruselj added a commit that referenced this issue Sep 6, 2021
@mkruselj
Revert PR #5000, abort param MIDI learn properly (#5005)
968c505 
Closes #5004
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template MIDI MIDI support related UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Revert PR #5000, abort param MIDI learn properly mkruselj/surge
2 participants
@mkruselj @cannero