Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual keyboard should always receive keypresses when possible #4930

Closed
mkruselj opened this issue Aug 27, 2021 · 5 comments · Fixed by #5003
Closed

Virtual keyboard should always receive keypresses when possible #4930

mkruselj opened this issue Aug 27, 2021 · 5 comments · Fixed by #5003
Labels
Feature Request New feature request Standalone Issues pertaining to Surge standalone application and CLI (command line interface) UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.0

Comments

@mkruselj
Copy link
Collaborator

So currently, one first needs to click on the virtual keyboard to make it take keyboard focus, and then QWERTY works to play it.

I hope there's a way to force VKB to always take keyboard input, unless we're typing in a parameter value, or typing in patch store dialog, or typing in a miniedit. 🤞
@mkruselj mkruselj added Feature Request New feature request UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Standalone Issues pertaining to Surge standalone application and CLI (command line interface) labels Aug 27, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Aug 27, 2021
@mkruselj
Copy link
Collaborator Author

Also, it should only take focus on keys it's actually using. If we press any of our internal keybindings, it should forward those for execution.

@baconpaul
Copy link
Collaborator

our internal keybindings need to be on the parent no the sge. easy enough change!

@VincyZed
Copy link
Collaborator

Possibly related:
Pressing tab to arm mod mode works now, but only if I clicked somewhere on the UI before.
If I click on the plugin wrapper window frame to move the plugin window, it activates the tab function of FL instead, which is cycle between opened windows.

@baconpaul
Copy link
Collaborator

my fix didn't work
"when possible" may be "never", in which case, in the most pedantic sense, I could close this issue as done.

baconpaul added a commit to baconpaul/surge that referenced this issue Sep 6, 2021
@baconpaul
Virtual Keyboard always gets Key events
70911e2 
If surge doesn't eat em, give the keyboard a try. Also
take focus in the MiniEdit.

Closes surge-synthesizer#4930
@baconpaul baconpaul mentioned this issue Sep 6, 2021
Merged
@baconpaul
Copy link
Collaborator

"when possible" was "when applying above diff" :)

mkruselj pushed a commit that referenced this issue Sep 6, 2021
@baconpaul
Virtual keyboard always gets key events (#5003)
6dc4b74 
If Surge doesn't eat em, give the keyboard a try. Also
take focus in the MiniEdit.

Closes #4930
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request New feature request Standalone Issues pertaining to Surge standalone application and CLI (command line interface) UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Virtual Keyboard always gets Key events baconpaul/surge
3 participants
@mkruselj @baconpaul @VincyZed