Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSEG editor visually choppy compared to 1.9 #4929

Closed
mkruselj opened this issue Aug 27, 2021 · 1 comment · Fixed by #5044 or #5046
Closed

MSEG editor visually choppy compared to 1.9 #4929

mkruselj opened this issue Aug 27, 2021 · 1 comment · Fixed by #5044 or #5046
Labels
Before Beta If these are open we can't really call ourselves beta Bug Report Item submitted using the Bug Report template Performance Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UI Issues related to UI look&feel
Milestone
Surge XT 1.0

Comments

@mkruselj
Copy link
Collaborator

Please profile. Things feel like 4 times slower visually. Here's a 30 FPS GIF that hopefully showcases a bit of what is happening.

msegchoppy
@mkruselj mkruselj added UI Issues related to UI look&feel Performance Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE labels Aug 27, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Aug 27, 2021
@baconpaul baconpaul added the Before Beta If these are open we can't really call ourselves beta label Sep 6, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Sep 10, 2021
@baconpaul
Improve MSEG Performance on Windows
b643cd9 
Stroked dotted lines are apparently dogs

Closes surge-synthesizer#4929
@baconpaul baconpaul mentioned this issue Sep 10, 2021
Merged
baconpaul added a commit that referenced this issue Sep 10, 2021
@baconpaul
Improve MSEG Performance on Windows (#5044)
a230101 
Stroked dotted lines are apparently dogs

Closes #4929
@mkruselj
Copy link
Collaborator Author

#5044 improves this very well (we don't need to do the solid line, it's fine with faux dotted lines as you did, Paul), however there's very jumpy redraw now if all we do is quick horizontal movement of a node. Commenting out the LFO display redraw at L2586 of MSEGEditor.cpp makes it silky smooth.

Reopening this one, but not for long!

@mkruselj mkruselj reopened this Sep 10, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Sep 10, 2021
@baconpaul
Another MSEG Performance Tweak
584980d 
Be more parsimonious with repaints when model changes. Rather than
force paint the entire UI, speed-gated repaint just the lfo display

Closes surge-synthesizer#4929
@baconpaul baconpaul mentioned this issue Sep 10, 2021
Merged
mkruselj pushed a commit that referenced this issue Sep 10, 2021
@baconpaul
Another MSEG Performance Tweak (#5046)
464d5c8 
Be more parsimonious with repaints when model changes. Rather than
force paint the entire UI, speed-gated repaint just the lfo display

Closes #4929
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Before Beta If these are open we can't really call ourselves beta Bug Report Item submitted using the Bug Report template Performance Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UI Issues related to UI look&feel
Projects
None yet
Milestone
Surge XT 1.0
2 participants
@mkruselj @baconpaul