Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FXUserPresetManager and ModulationManager statics lifted onto storage #4921

Closed
baconpaul opened this issue Aug 26, 2021 · 0 comments · Fixed by #4944
Closed

FXUserPresetManager and ModulationManager statics lifted onto storage #4921

baconpaul opened this issue Aug 26, 2021 · 0 comments · Fixed by #4944
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme Infrastructure Issues related to repository, CI/CD, installers, etc.
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

The statics are fine technically and sharing them across instances is OK also technically
but it still makes me squeamish
just a note to stay squeamish or fix before we ship xt.
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Aug 26, 2021
@mkruselj mkruselj added Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme Infrastructure Issues related to repository, CI/CD, installers, etc. labels Aug 26, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 29, 2021
@baconpaul
Move Presets to Objects
9e9c69b 
FxUserPreset and ModulatorPreset had static banks which was fine
but made me squeamish so undo that. Closes surge-synthesizer#4921
@baconpaul baconpaul mentioned this issue Aug 29, 2021
Merged
baconpaul added a commit that referenced this issue Aug 29, 2021
@baconpaul
Move Presets to Objects (#4944)
14b2e18 
FxUserPreset and ModulatorPreset had static banks which was fine
but made me squeamish so undo that. Closes #4921
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme Infrastructure Issues related to repository, CI/CD, installers, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Move Presets to Objects baconpaul/surge
2 participants
@mkruselj @baconpaul