Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening patches you have saved in Logic library crashes the app #4913

Closed
LelleOstman opened this issue Aug 25, 2021 · 21 comments
Closed

Opening patches you have saved in Logic library crashes the app #4913

LelleOstman opened this issue Aug 25, 2021 · 21 comments
Labels
Bug Report Item submitted using the Bug Report template Host Specific Issues related to specific host(s) or host features
Milestone

Comments

@LelleOstman
Copy link

When I try to open my own patches from the Logic Pro library The whole of Logic crashes when I select a patch and open Surge. I have not saved the patches inside of Surge but have used the Logic menu inside the plug in window.

Surge version 1.9.0.91069f8 Au on intel Core i7 - 4870HQ 64 bit

  • macOS Big Sur 11.5.2
  • Host: Logic Pro 10.6.3
@LelleOstman LelleOstman added the Bug Report Item submitted using the Bug Report template label Aug 25, 2021
@baconpaul
Copy link
Collaborator

OK so I just tried it with a very similar setup and didn't get a crash

I opened surge in init, changed some things, did logic menu / save and saved it

i then created a new track, loaded surge, did logic menu / load and loaded it

and it loaded

so i wonder if something has corrupted your preset somehow

when logic crashes it may say 'report' and then show a stack trace. Can you send us that?

@LelleOstman
Copy link
Author

LelleOstman commented Aug 25, 2021 via email

@mkruselj mkruselj added the Host Specific Issues related to specific host(s) or host features label Aug 26, 2021
@mkruselj mkruselj added this to the Currently Unscheduled milestone Aug 26, 2021
@baconpaul
Copy link
Collaborator

That is very useful
What I think is happening is the daw zoom state is getting saved as a logic patch and our restore of that is coming before the editor is set up, I see the 19 code path that could crash after set zoom
For our next release we’ve rewritten this entire code path so I gotta think about what to do. We don’t plan to patch 1.9 and none of this crashing code is in the codebase any more.
thank you very much for the crash log,

@LelleOstman
Copy link
Author

LelleOstman commented Sep 1, 2021 via email

@baconpaul
Copy link
Collaborator

Oh excellent! When you release your album let us know.
I'm going to make sure this doesn't happen with our new release a couple of times, and if it doesn't i'll close this once we are in beta. Will let you know by posting to this issue. Sept or Oct. Thanks!

@LelleOstman
Copy link
Author

LelleOstman commented Sep 1, 2021 via email

@mkruselj
Copy link
Collaborator

@LelleOstman Can you perhaps try if this issue happens in Surge XT nightly? It's a separate install so your Surge 1.9 installation won't be affected. You can download it here.

@mkruselj mkruselj added the Awaiting User Information Self-explanatory label Sep 15, 2021
@baconpaul
Copy link
Collaborator

Oh I was gonna test this this week @mkruselj - if it does break I can catch it in a debugger and I could repro in 19

@LelleOstman
Copy link
Author

LelleOstman commented Sep 16, 2021 via email

@mkruselj
Copy link
Collaborator

That's great to hear! It means we can close this issue (1.9 codepath will not be updated anymore).

Thanks for the report back!

@mkruselj mkruselj removed the Awaiting User Information Self-explanatory label Sep 16, 2021
@baconpaul
Copy link
Collaborator

Yes thanks!,

@LelleOstman
Copy link
Author

LelleOstman commented Sep 18, 2021 via email

@baconpaul
Copy link
Collaborator

All your old patches will work in XT, but it will have a different id so you will need to move them over to your new directories

@baconpaul
Copy link
Collaborator

(We will provide documentation and perhaps tooling on how to do this closer to final release)

@mkruselj
Copy link
Collaborator

I think Lelle asks about his 1.9 Logic saved patches. Yeah those will not convert to XT - you will have to save them using Surge's patch storing mechanism, then load them into XT, then save them again using Logic's saving facilities.

@LelleOstman
Copy link
Author

LelleOstman commented Sep 18, 2021 via email

@baconpaul
Copy link
Collaborator

you can continue using it. none of our software is time restricted
but you probably want to update it fairly recently. We keep adding and fixing things and it is still a bit alpha-y

@baconpaul
Copy link
Collaborator

fairly frequently sorry

@LelleOstman
Copy link
Author

LelleOstman commented Sep 25, 2021 via email

@baconpaul
Copy link
Collaborator

If you run a recent surge xt you can do menu / skins library and it will take you to a collection we are starting to curate ahead of our 1.0 release

@baconpaul
Copy link
Collaborator

You need an xt from the last 5 days or so for that tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template Host Specific Issues related to specific host(s) or host features
Projects
None yet
Development

No branches or pull requests

3 participants