Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XT: Step Sequencer and other Modulation editor graphical bugs #4877

Closed
2 tasks done
VincyZed opened this issue Aug 20, 2021 · 2 comments · Fixed by #4942
Closed
2 tasks done

XT: Step Sequencer and other Modulation editor graphical bugs #4877

VincyZed opened this issue Aug 20, 2021 · 2 comments · Fixed by #4942
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UI Issues related to UI look&feel
Milestone
Surge XT 1.0

Comments

@VincyZed
Copy link
Collaborator

VincyZed commented Aug 20, 2021 •
edited by mkruselj
Loading

Here are some UI glitches I found using the Step Sequencer mod source (and in some cases other mod sources) in XT so far:

(@baconpaul: I edited this into a checklist)

  • Click + dragging allows you to drag outside of the SS boundaries (it will move the LFO shape if you continue dragging to the left of the SS, for instance).
  • The mouse pointer doesn't update to the pointed finger when hovering over the MSEG display like it does in 1.9 to indicate you can click on it. This also applies to the formula modulator.

Hope that helps! :) I may add more stuff below if I find more.
@VincyZed VincyZed added UI Issues related to UI look&feel Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE labels Aug 20, 2021
@VincyZed VincyZed added this to the Surge XT 1.0 milestone Aug 20, 2021
@baconpaul
Copy link
Collaborator

super useful thank you

mkruselj added a commit to mkruselj/surge that referenced this issue Aug 26, 2021
@mkruselj
Fix a number of step seq UI/UX regressions
bfb8a50 
Addresses surge-synthesizer#4877

Also:
- properly update state of Pencil button when toggling
  MSEG/formula overlays by clicking on the display
- rename msegEditSwitch SGE member to something more universal
- make elementary rects of LFO widget member variables,
  remove &within argument from pain functions as a consequence
- step seq value is added directly on mouse down, not just on mouse move
@mkruselj mkruselj mentioned this issue Aug 26, 2021
Merged
@mkruselj
Copy link
Collaborator

Bunch of fixes incoming, @VincyZed!

mkruselj added a commit that referenced this issue Aug 27, 2021
@mkruselj
Fix a number of step seq UI/UX regressions (#4924)
47f3025 
Addresses #4877

Also:
- properly update state of Pencil button when toggling
  MSEG/formula overlays by clicking on the display
- rename msegEditSwitch SGE member to something more universal
- make elementary rects of LFO widget member variables,
  remove &within argument from pain functions as a consequence
- step seq value is added directly on mouse down, not just on mouse move
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 28, 2021
@baconpaul
Finish of LFO etc bugs
dc7b84f 
1. Hand shows over Waveform for MSEG and Formula
2. StepSequencer drags limited to stepsequencer actions

Closes surge-synthesizer#4877
@baconpaul baconpaul mentioned this issue Aug 28, 2021
Merged
baconpaul added a commit that referenced this issue Aug 28, 2021
@baconpaul
Finish of LFO etc bugs (#4942)
8075918 
1. Hand shows over Waveform for MSEG and Formula
2. StepSequencer drags limited to stepsequencer actions

Closes #4877
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UI Issues related to UI look&feel
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Finish of LFO etc bugs baconpaul/surge
3 participants
@mkruselj @baconpaul @VincyZed