Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XT - Drag-and-drop of mod sources behavior and appearance issues #4858

Closed
VincyZed opened this issue Aug 17, 2021 · 2 comments · Fixed by #4891
Closed

XT - Drag-and-drop of mod sources behavior and appearance issues #4858

VincyZed opened this issue Aug 17, 2021 · 2 comments · Fixed by #4891
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UI Issues related to UI look&feel
Milestone
Surge XT 1.0

Comments

@VincyZed
Copy link
Collaborator

image

So basically a couple of things have changed since 1.9:

  1. You can drag and drop mod sources without pressing Ctrl. (I think that this is a good change FWIW)
  2. However drag and dropping mod sources over sliders to bring up the mod amount numerical input window doesn't work, and doesn't work while holding Ctrl either.
  3. When dragging a mod source, instead of making a visual copy of the blue rectangle, it moves it, creating a hole at its original position in the routing bar.
  4. When dragging over sliders, the mod rectangle is drawn below sliders, where it should be drawn over them.
  5. This wasn't there in 1.9 either, but it would be nice if elements that can be modulated showed either the hover state, or even better the corresponding blue slider appearing when hovering over an element. Then when dropping, show the popup value as usual.
@VincyZed VincyZed added Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UI Issues related to UI look&feel labels Aug 17, 2021
@VincyZed VincyZed added this to the Surge XT 1.0 milestone Aug 17, 2021
@baconpaul
Copy link
Collaborator

oh yeah that's broken
fwiw the macros do swap if you drag and drop between them though. At least that handler works :)

@baconpaul
Copy link
Collaborator

an accessibility change i made to group components broke this. i have it fixed now. PR shortly.

baconpaul added a commit to baconpaul/surge that referenced this issue Aug 22, 2021
@baconpaul
Restore Drag and Drop after Accessibility changes
fffd7d6 
To make accessibility more reasonable I group components in overlays
but those overlays messed up z order a bit and also made the component
heirarchy deeper. So handle both of those and allow dnd to work with
a deeper heirarchy

Closes surge-synthesizer#4858
@baconpaul baconpaul mentioned this issue Aug 22, 2021
Merged
baconpaul added a commit that referenced this issue Aug 22, 2021
@baconpaul
Restore Drag and Drop after Accessibility changes (#4891)
870c65d 
To make accessibility more reasonable I group components in overlays
but those overlays messed up z order a bit and also made the component
heirarchy deeper. So handle both of those and allow dnd to work with
a deeper heirarchy

Closes #4858
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UI Issues related to UI look&feel
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Restore Drag and Drop after Accessibility changes baconpaul/surge
2 participants
@baconpaul @VincyZed