Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surge XT - Small white border around value popups #4857

Closed
VincyZed opened this issue Aug 17, 2021 · 1 comment · Fixed by #4860
Closed

Surge XT - Small white border around value popups #4857

VincyZed opened this issue Aug 17, 2021 · 1 comment · Fixed by #4860
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UI Issues related to UI look&feel
Milestone
Surge XT 1.0

Comments

@VincyZed
Copy link
Collaborator

image
We can see it over dark backgrounds. I've tried at different zoom levels from 100% onwards and I saw that it stopped doing this at 200% and up.

Here's 1.9 as comparison:
image

I don't know if this just happens on Windows and on certain screen resolutions. I guess some testing on other configs (like other resolutions) would be beneficial here?
@VincyZed VincyZed added UI Issues related to UI look&feel Bug Report Item submitted using the Bug Report template labels Aug 17, 2021
@VincyZed VincyZed added this to the Surge XT 1.0 milestone Aug 17, 2021
@VincyZed VincyZed added the Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE label Aug 17, 2021
@baconpaul
Copy link
Collaborator

oh huh that looks like an int -> float quantization error. I can paint that differently though to avoid that
thank you!

baconpaul added a commit to baconpaul/surge that referenced this issue Aug 17, 2021
@baconpaul
Paint InfoWindow border differently
d6ec62c 
We used to draw a rect after a fill but at some zoom levels
on windows this 'leaked' background so instead fill border
then fill fill reduced

Closes surge-synthesizer#4857
@baconpaul baconpaul mentioned this issue Aug 17, 2021
Merged
baconpaul added a commit that referenced this issue Aug 17, 2021
@baconpaul
Paint InfoWindow border differently (#4860)
81612dd 
We used to draw a rect after a fill but at some zoom levels
on windows this 'leaked' background so instead fill border
then fill fill reduced

Closes #4857
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UI Issues related to UI look&feel
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Paint InfoWindow border differently baconpaul/surge
2 participants
@baconpaul @VincyZed