Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I think I can remove metaparam_offset #4854

Closed
baconpaul opened this issue Aug 17, 2021 · 1 comment · Fixed by #4879
Closed

I think I can remove metaparam_offset #4854

baconpaul opened this issue Aug 17, 2021 · 1 comment · Fixed by #4879
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

metaparam_offset exists so we could do our hand made VST3 mapping to macros
but now I make those macros attach to params through SurgeMacroToJuceParamAdapter
so in theory all the metaparam_offset code in the code can go away
and things will work
and be more rational

lets see.
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Aug 17, 2021
@baconpaul baconpaul added the Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme label Aug 17, 2021
@mkruselj
Copy link
Collaborator

🤞

baconpaul added a commit to baconpaul/surge that referenced this issue Aug 21, 2021
@baconpaul
Remove metaparam_offset
547429b 
With the advent of JUCE we no longer map the macros
to DAW parameters with an integer offset but rather have
a distinct class which handles Macros. Therefore we can
remove all the metaparam_offset ranges in the code

Closes surge-synthesizer#4854
@baconpaul baconpaul mentioned this issue Aug 21, 2021
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 21, 2021
@baconpaul
Remove metaparam_offset
4719566 
With the advent of JUCE we no longer map the macros
to DAW parameters with an integer offset but rather have
a distinct class which handles Macros. Therefore we can
remove all the metaparam_offset ranges in the code

Closes surge-synthesizer#4854
baconpaul added a commit that referenced this issue Aug 21, 2021
@baconpaul
Remove metaparam_offset (#4879)
5cf8ec7 
With the advent of JUCE we no longer map the macros
to DAW parameters with an integer offset but rather have
a distinct class which handles Macros. Therefore we can
remove all the metaparam_offset ranges in the code

Closes #4854
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Remove metaparam_offset baconpaul/surge
2 participants
@mkruselj @baconpaul