Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resources for Binaries are a bit all over #4846

Closed
2 tasks
baconpaul opened this issue Aug 16, 2021 · 0 comments · Fixed by #4848
Closed
2 tasks

Resources for Binaries are a bit all over #4846

baconpaul opened this issue Aug 16, 2021 · 0 comments · Fixed by #4848
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

We have two binaries, a SurgeCore which is linked by SurgeShared and a BinaryData which is linked by surge-xt. That's fine but

  • Rename BinaryData to SurgeSynthData and SurgeCore to SurgeSharedData
  • Make sure that the assets for SurgeSharedData come from one place, and the assets for SurgeSynthData from another, and not some mis-mash of globs and hashes like we have today
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Aug 16, 2021
@baconpaul baconpaul added the Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme label Aug 16, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 16, 2021
@baconpaul
Clean Up Binary Libs and Locations
e419241 
Closes surge-synthesizer#4846
@baconpaul baconpaul mentioned this issue Aug 16, 2021
Merged
baconpaul added a commit that referenced this issue Aug 16, 2021
@baconpaul
Clean Up Binary Libs and Locations (#4848)
8b9893c 
Closes #4846
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Refactoring General code refactoring and cleanup issues like names, unused variables, warnings, fixme
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Clean Up Binary Libs and Locations baconpaul/surge
1 participant
@baconpaul