Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deform in StepSequencer looks broken #4821

Closed
ghost opened this issue Aug 10, 2021 · 5 comments · Fixed by #4827
Closed

Deform in StepSequencer looks broken #4821

ghost opened this issue Aug 10, 2021 · 5 comments · Fixed by #4827
Milestone

Comments

@ghost
Copy link

ghost commented Aug 10, 2021

Linux 64bit
b0bb41c

I don't know since when, just saw this when comparing older patches
with rhythmic sequences that sounded off.

I made a simple example patch to demonstrate what i mean (with deform 25%):
huiuiui.fxp.zip
which looks (and sounds) like this in 1.9
19_stepseq
and like this in xt
XT_stepseq

@baconpaul baconpaul added this to the Surge XT 1.0 milestone Aug 10, 2021
@baconpaul
Copy link
Collaborator

hmmm somewhat disconcertingly that patch loads the same way on mac with 1.9 and xt

that might mean there's some uninitialized memory somewhere though

i wonder if the shuffle extend is at fault perhaps?

@mkruselj when you get a chance can you try this patch windows with xt and 19? I'll look linux also when i next boot a vm.

but can't repro on mac so will require a bit of digging.

@baconpaul
Copy link
Collaborator

Huh well confirmed that it is broken on linux.

@baconpaul
Copy link
Collaborator

Confirmed also that backing down ea252d2 fixes it.
But again still not sure why

@baconpaul
Copy link
Collaborator

Got it

@mkruselj the arguments to limit_range are x, low, high not low, high, x :)

baconpaul added a commit to baconpaul/surge that referenced this issue Aug 11, 2021
limit-range arguments were misordered in shuffle
For some patches on some OSes this would give unexpected
and incorrect results.
Closes surge-synthesizer#4821
baconpaul added a commit that referenced this issue Aug 11, 2021
limit-range arguments were misordered in shuffle
For some patches on some OSes this would give unexpected
and incorrect results.
Closes #4821
@mkruselj
Copy link
Collaborator

Whoopsie! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants