Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XT passes audio input instead of blocking it #4766

Closed
mkruselj opened this issue Jul 21, 2021 · 2 comments · Fixed by #4779
Closed

XT passes audio input instead of blocking it #4766

mkruselj opened this issue Jul 21, 2021 · 2 comments · Fixed by #4779
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE VST3 VST3 plugin related issues
Milestone
Surge XT 1.0

Comments

@mkruselj
Copy link
Collaborator

1.9 didn't do this. Try these steps:

  1. Load XT on a track
  2. Add an audio file on the same track
  3. Hit play on transport

In 1.9 you would hear nothing until you pick the Audio In oscillator or use the vocoder. In XT you hear it straight away, and worse yet, once you do route it into Audio In, it doesn't kill the pass-through audio so you hear it twice. And there's no way to kill that dry signal.
@mkruselj mkruselj added Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE labels Jul 21, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Jul 21, 2021
@mkruselj mkruselj added the VST3 VST3 plugin related issues label Jul 21, 2021
@baconpaul
Copy link
Collaborator

https://forum.juce.com/t/question-on-vst3-bus-layout/47014

there's the juce forum discussion

this will almost definitely only impact reaper (remember we filed a reaper bug report on this behavior) but we do want it correct of course.

@baconpaul
Copy link
Collaborator

oh and for now you can work around it by routing audio from a separate track into the side chain etc... but that's not a fix.

baconpaul added a commit to baconpaul/surge that referenced this issue Jul 27, 2021
@baconpaul
Upgrade to juce DEVELOP branch; Fix VST3 Audio Routing
0650aee 
1. Upgrade to juce develop
2. Use the new getPluginHasMainInput function to route sidechain
   properly in reaper. Closes surge-synthesizer#4766
@baconpaul baconpaul mentioned this issue Jul 27, 2021
Merged
baconpaul added a commit that referenced this issue Jul 27, 2021
@baconpaul
Upgrade to juce DEVELOP branch; Fix VST3 Audio Routing (#4779)
e32b41c 
1. Upgrade to juce develop
2. Use the new getPluginHasMainInput function to route sidechain
   properly in reaper. Closes #4766
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE VST3 VST3 plugin related issues
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Upgrade to juce DEVELOP branch; Fix VST3 Audio Routing baconpaul/surge
2 participants
@mkruselj @baconpaul