Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XT doesn't recall plugin state on project load in Reaper #4759

Closed
mkruselj opened this issue Jul 18, 2021 · 12 comments
Closed

XT doesn't recall plugin state on project load in Reaper #4759

mkruselj opened this issue Jul 18, 2021 · 12 comments
Labels
Bug Report Item submitted using the Bug Report template Host Specific Issues related to specific host(s) or host features Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE
Milestone
Surge XT 1.0

Comments

@mkruselj
Copy link
Collaborator

1, Open Reaper
2. Load Surge XT
3. Pick any patch
4. Save project and close it
5. Reopen project

What you get: Init Saw, instead of the patch you picked.
@mkruselj mkruselj added Host Specific Issues related to specific host(s) or host features Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE labels Jul 18, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Jul 18, 2021
@baconpaul
Copy link
Collaborator

Quick q
If you set your default patch to something else does that pop up?

@mkruselj
Copy link
Collaborator Author

Yup!

@baconpaul
Copy link
Collaborator

Right. Damnit.

@baconpaul
Copy link
Collaborator

Anyway tbis one is too
Of my stack
To fix next

@baconpaul
Copy link
Collaborator

So interestingly there's three startup loads when I load reaper for me

  1. The init patch
  2. Overwwritten by the stored in song patch
  3. Overwritten by some other random thing

I think 3 is coming from the VST3 preset mechanism but I am not sure. Debugging.

But it's not the init patch thing.

I'll also check AU Logic.

@baconpaul
Copy link
Collaborator

baconpaul commented Jul 18, 2021 •
edited
Loading

yeah it's a mistake in my implementation of the vst3 preset mechanism. Almost have it.

@baconpaul
Copy link
Collaborator

OK I have a fix and I am sure it is correct but I've onlytestyd it on mac.
I'll leave this open until we get confirm it fixes windows reaper also and I will test logic too.
but let me put the PR in.

baconpaul added a commit to baconpaul/surge that referenced this issue Jul 18, 2021
@baconpaul
Correct built in preset index error
e136abe 
There was a built in preset index error which forced
Reaper (and perhaps other hosts) to force-override the song
state in some cases.

Addresses surge-synthesizer#4759
@baconpaul baconpaul mentioned this issue Jul 18, 2021
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 18, 2021
@baconpaul
Disable presets-to-host mechanism for now
3a00749 
There was a built in preset index error which forced
Reaper (and perhaps other hosts) to force-override the song
state in some cases. Even when fixed, though, logic clobbers
if you have selected. Need to figure this out later so just
turn it all off for now.

Addresses surge-synthesizer#4759

f
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 18, 2021
@baconpaul
Disable presets-to-host mechanism for now
2fcfae4 
There was a built in preset index error which forced
Reaper (and perhaps other hosts) to force-override the song
state in some cases. Even when fixed, though, logic clobbers
if you have selected. Need to figure this out later so just
turn it all off for now.

Addresses surge-synthesizer#4759

f
baconpaul added a commit that referenced this issue Jul 18, 2021
@baconpaul
Disable presets-to-host mechanism for now (#4760)
5058ddf 
There was a built in preset index error which forced
Reaper (and perhaps other hosts) to force-override the song
state in some cases. Even when fixed, though, logic clobbers
if you have selected. Need to figure this out later so just
turn it all off for now.

Addresses #4759

f
@baconpaul
Copy link
Collaborator

Confirmed fixed windows reaper with that disabling.

@eliasdorneles
Copy link

Hello,

I have a similar problem with Surge XT LV2 plugin, on Reaper (on Linux, Ubuntu 22.04).

Steps:

  1. Create a new Reaper project
  2. Setup a track with Surge XT plugin, pick any patch (e.g. Bass 2), do not make any modification
  3. Save project, close Reaper
  4. Reopen reaper, reopen project

What you get: the plugin is loaded as if the patch is modified, the patch name has a * and the sound is different as well.

Screenshot on a brand-new project just opened:

image

@eliasdorneles
Copy link

I've just tried now the VST3 plugin, and can't reproduce the bug with it -- so it seems it's indeed a problem in the LV2 plugin implementation.

@mkruselj
Copy link
Collaborator Author

Moving forward we will not be supporting LV2 anymore, just FYI.

@eliasdorneles
Copy link

ah ok, good to know

@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Host Specific Issues related to specific host(s) or host features Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE
Projects
None yet
Milestone
Surge XT 1.0
Development

No branches or pull requests
3 participants
@eliasdorneles @mkruselj @baconpaul