GCC Release build error

[ghost]

Linux 64 bit
All formats but Release only

When compiling with GCC 9 it currently errors with the following warnings
(it builds when setting -DCMAKE_CXX_FLAGS="-Wno-error=stringop-overflow=" )

In file included from /usr/include/stdio.h:867,
                 from /home/xxx/surge/src/common/globals.h:19,
                 from /home/xxx/surge/src/gui/SurgeGUIEditor.h:18,
                 from /home/xxx/surge/src/gui/SurgeGUIEditorValueCallbacks.cpp:16:
In function ‘int snprintf(char*, size_t, const char*, ...)’,
    inlined from ‘virtual int32_t SurgeGUIEditor::controlModifierClicked(Surge::GUI::IComponentTagValue*, const juce::ModifierKeys&, bool)’ at /home/xxx/surge/src/gui/SurgeGUIEditorValueCallbacks.cpp:46:17:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:35: warning: ‘int __builtin___snprintf_chk(char*, long unsigned int, int, long unsigned int, const char*, ...)’ specified bound 256 exceeds destination size 16 [-Wstringop-overflow=]
   67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   68 |        __bos (__s), __fmt, __va_arg_pack ());
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘int snprintf(char*, size_t, const char*, ...)’,
    inlined from ‘virtual int32_t SurgeGUIEditor::controlModifierClicked(Surge::GUI::IComponentTagValue*, const juce::ModifierKeys&, bool)’ at /home/xxx/surge/src/gui/SurgeGUIEditorValueCallbacks.cpp:49:17:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:35: warning: ‘int __builtin___snprintf_chk(char*, long unsigned int, int, long unsigned int, const char*, ...)’ specified bound 256 exceeds destination size 16 [-Wstringop-overflow=]
   67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   68 |        __bos (__s), __fmt, __va_arg_pack ());
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘int snprintf(char*, size_t, const char*, ...)’,
    inlined from ‘virtual int32_t SurgeGUIEditor::controlModifierClicked(Surge::GUI::IComponentTagValue*, const juce::ModifierKeys&, bool)’ at /home/xxx/surge/src/gui/SurgeGUIEditorValueCallbacks.cpp:52:17:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:67:35: warning: ‘int __builtin___snprintf_chk(char*, long unsigned int, int, long unsigned int, const char*, ...)’ specified bound 256 exceeds destination size 16 [-Wstringop-overflow=]
   67 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   68 |        __bos (__s), __fmt, __va_arg_pack ());
      |        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[baconpaul]

aww man i thought we built with gcc9 in the pipeline to make sure we catch that. let me look.

[ghost]

you do, but its all debug builds except unittest
and debug builds fine

[baconpaul]

Ok thanks! I’ll break the pipelines then fix the code tomorrow and close tbis then

appreciated

[baconpaul]

broke pipelines in a PR yup. The LV2 now builds release (I chose the LV2 since it is the smaller build - we just build surge not the full ci set).

Pushed a fix. If that works I'll merge it and ti will close this issue

tx