Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jumpy behavior when holding Shift while dragging a slider #4738

Closed
mkruselj opened this issue Jul 10, 2021 · 2 comments · Fixed by #4747
Closed

Jumpy behavior when holding Shift while dragging a slider #4738

mkruselj opened this issue Jul 10, 2021 · 2 comments · Fixed by #4747
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.0

Comments

@mkruselj
Copy link
Collaborator

shiftjumpy

Every time the slider jumps, I pressed Shift. This is not how it worked in 1.9 and before - it just slowed down the slider movement from current value, no jumps. Doesn't matter if cursor is hidden when dragging or not.

What could the cause be?
@mkruselj mkruselj added UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Bug Report Item submitted using the Bug Report template labels Jul 10, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Jul 10, 2021
@baconpaul
Copy link
Collaborator

I wonder if I have a limit or a rounding wrong?
I would place a print/debug in notifyValueChange in the mixin and see what the getValue is
but it could also be (and I bet it is) that I set the value but not the quantized_value - the slider kinda has two values
Just guesses quickly on where I would start

@mkruselj mkruselj added the Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE label Jul 10, 2021
@baconpaul
Copy link
Collaborator

ahh now i understand
this occurs if you press shift within a drag
gotcha
so start a drag and while draggin press and release the shift button

baconpaul added a commit to baconpaul/surge that referenced this issue Jul 13, 2021
@baconpaul
Mouse shift handling correction
90a88e4 
The mouse distance restated values based on base + total motion
but this broke with shift which kncoked you out of whack so
keep an incremental distance and += the value or modvalue
based on that

Closes surge-synthesizer#4738
@baconpaul baconpaul mentioned this issue Jul 13, 2021
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 13, 2021
@baconpaul
Mouse shift handling correction
f7597ca 
The mouse distance restated values based on base + total motion
but this broke with shift which kncoked you out of whack so
keep an incremental distance and += the value or modvalue
based on that

Closes surge-synthesizer#4738
baconpaul added a commit that referenced this issue Jul 13, 2021
@baconpaul
Mouse shift handling correction (#4747)
57bb23d 
The mouse distance restated values based on base + total motion
but this broke with shift which kncoked you out of whack so
keep an incremental distance and += the value or modvalue
based on that

Closes #4738
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Mouse shift handling correction baconpaul/surge
2 participants
@mkruselj @baconpaul