Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune button doesn't toggle loaded tuning on Windows #4729

Closed
mkruselj opened this issue Jul 7, 2021 · 1 comment · Fixed by #4730
Closed

Tune button doesn't toggle loaded tuning on Windows #4729

mkruselj opened this issue Jul 7, 2021 · 1 comment · Fixed by #4730
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Jul 7, 2021

Exactly as subject says.

tune

@mkruselj mkruselj added UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Bug Report Item submitted using the Bug Report template labels Jul 7, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Jul 7, 2021
@baconpaul
Copy link
Collaborator

So here’s how it works on Mac at head

with a tuning loaded the button toggles
If you toggle tuning on and choose standard tuning it is no longer toggleable

so I think what we need to do is - like I did with the rest of the tuning stack in 19 - write the state machine charefulky then see where I introduced the bug in the ui rewrite. Easy but requires a wee bit of caution since we need to deal with the rebuild and the non rebuild state

mkruselj added a commit to mkruselj/surge that referenced this issue Jul 7, 2021
baconpaul pushed a commit that referenced this issue Jul 7, 2021
Fix for #4729 but I'd like @baconpaul to verify on Mac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants