Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last chance doesn't work above widgets #4708

Closed
mkruselj opened this issue Jul 2, 2021 · 3 comments · Fixed by #4945
Closed

Last chance doesn't work above widgets #4708

mkruselj opened this issue Jul 2, 2021 · 3 comments · Fixed by #4945
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone

Comments

@mkruselj
Copy link
Collaborator

mkruselj commented Jul 2, 2021

Middle mouse click above slider, multiswitch, osc display etc. doesn't toggle mod assign mode like it used to in 1.9.

@mkruselj mkruselj added UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE labels Jul 2, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Jul 2, 2021
@baconpaul
Copy link
Collaborator

It’s also worth noting that if you add the parent as a mouse listener to the child and set setInterceptsMouseClicks(true, false) for the parent, MouseEvent::originalComponent will actually point to the child. To use your example:

// whichever mouse callback(s) you need
void mouseDown(const MouseEvent &e)
{
    if (e.mods.isRightButtonDown())
        // handle right click
    else if (e.originalComponent != this)
        e.originalComponent->mouseDown(e);
}

from https://forum.juce.com/t/how-to-intercept-some-mouse-events-in-the-parent-component/32653/6 is the rough answer inside MainFrame. Probably. This one is trickier since mouse events don't cascade in juce like they do in VSTGUI

@mkruselj
Copy link
Collaborator Author

mkruselj commented Jul 6, 2021

Semi-related - last chance click should also dismiss typeins, like it did in 1.9.

baconpaul added a commit to baconpaul/surge that referenced this issue Aug 28, 2021
@baconpaul
Copy link
Collaborator

baconpaul/last-chance-4708 got it started and @mkruselj can bring it home

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants