Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twist, LPG and FM #4689

Closed
baconpaul opened this issue Jun 28, 2021 · 2 comments · Fixed by #5039
Closed

Twist, LPG and FM #4689

baconpaul opened this issue Jun 28, 2021 · 2 comments · Fixed by #5039
Labels
Before Beta If these are open we can't really call ourselves beta Bug Report Item submitted using the Bug Report template DSP Issues and feature requests related to sound generation in the synth FM Enhancements Oscillator Features or additions to the oscillator section
Milestone

Comments

@baconpaul
Copy link
Collaborator

From the massive kvr thread user https://www.kvraudio.com/forum/memberlist.php?mode=viewprofile&u=203660 reports:

Found a bug in the new TWIST dsp module ,
When lpg is enabled for osc 1 ( also the only osc enabled in the mixer ) and osc fm routing is set to 2--1 , fm depth to zero , this somehow influences osc 1 , bug goes away lpg is disabled .
Steps to reproduce
-for osc 1 choose TWIST , engine waveshaper ..increase fold to add some harmonic content
-Enable Low pass gate ( right click enable )
-Set low pass gate response to 40 % , decay to 100 %
-Set all mixer channels to zero except for osc 1
-Now alternatae between NO FM ,2-1 in the oscillator fm routing , make sure the FM amount slider is set to zero
Notice how switching between FM modes actually changes the sound of osc 1 while there is no FM going on , when one of thefm tabs is enabled , it actually shortens the lpg decay ??
Disabling the lpg mode gets rid of it

@baconpaul baconpaul added DSP Issues and feature requests related to sound generation in the synth FM Enhancements Oscillator Features or additions to the oscillator section Bug Report Item submitted using the Bug Report template labels Jun 28, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Jun 28, 2021
@baconpaul
Copy link
Collaborator Author

OK here's what I think is happening here

In regular twist we run 4 samples 'at a process time' and then load them into the resampler and so on.

In FM mode we can't do that - we have to run it one sample at a time

I think we have that wrong somewhere.

@mkruselj mkruselj changed the title Twist, lpg, and fm Twist, LPG and FM Jul 2, 2021
@baconpaul
Copy link
Collaborator Author

So if I change the sub-block size in non-FM to '1' it is identical to the FM case. But I'm not sure which is the right one. Tricky. I'll have to dig into the euro rack LPG code to find this.

@baconpaul baconpaul added the Before Beta If these are open we can't really call ourselves beta label Sep 6, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Sep 9, 2021
LPG was calculated incorrectly in non-FM mode due to block size
work. Correct this.

Closes surge-synthesizer#4689
baconpaul added a commit that referenced this issue Sep 9, 2021
LPG was calculated incorrectly in non-FM mode due to block size
work. Correct this.

Closes #4689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Before Beta If these are open we can't really call ourselves beta Bug Report Item submitted using the Bug Report template DSP Issues and feature requests related to sound generation in the synth FM Enhancements Oscillator Features or additions to the oscillator section
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant