Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl-click on mac isn't RMB equiv consistently #4672

Closed
baconpaul opened this issue Jun 22, 2021 · 0 comments · Fixed by #4699
Closed

Ctrl-click on mac isn't RMB equiv consistently #4672

baconpaul opened this issue Jun 22, 2021 · 0 comments · Fixed by #4699
Labels
Bug Report Item submitted using the Bug Report template macOS macOS related issues Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

Ctrl-click on mac

event.mods.isPopupMenu() is true
event.mods.isRightButton() is false
so the wrong thing happens

Actually do an RMB gesture (like two finger click) and it all works of course.

There's a hacky way to fix this (modify notifyControlModifierClicked like we did for double click) but the right way is when we jettison escape to use event.mods in CMC replacement and actually check isPopupMenu
@baconpaul baconpaul added Bug Report Item submitted using the Bug Report template macOS macOS related issues Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE labels Jun 22, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Jun 22, 2021
@mkruselj mkruselj added the UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. label Jun 22, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Jun 29, 2021
@baconpaul
RightButton is not the only PopupMenu Gesture
8a95d42 
RMB is not the only PopupMenu getsture on mac and we use
isPopupMenu consistently elsewhere. Here use the || to be
conservative

Closes surge-synthesizer#4672
@baconpaul baconpaul mentioned this issue Jun 29, 2021
Merged
baconpaul added a commit that referenced this issue Jun 30, 2021
@baconpaul
RightButton is not the only PopupMenu Gesture (#4699)
74ca24d 
RMB is not the only PopupMenu getsture on mac and we use
isPopupMenu consistently elsewhere. Here use the || to be
conservative

Closes #4672
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template macOS macOS related issues Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

RightButton is not the only PopupMenu Gesture baconpaul/surge
2 participants
@mkruselj @baconpaul