Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message when loading patch that exists both in factory and user data #4668

Closed
selenologist opened this issue Jun 11, 2021 · 2 comments · Fixed by #4897
Closed

Error message when loading patch that exists both in factory and user data #4668

selenologist opened this issue Jun 11, 2021 · 2 comments · Fixed by #4897
Labels
Bug Report Item submitted using the Bug Report template Patch Browser
Milestone
Surge XT 1.0

Comments

@selenologist
Copy link
Collaborator

Bug Description:
When a patch exists in both the user patch folder and the factory patch folder, e.g. my Luna/Leads/96 Osc Supersaw patch, attempting to load the patch from the user folder causes an error box to appear, then Surge behaves as the patch in the factory folder is loaded. A screenshot of the error box is attached.

Surge Version

  • Version: Surge XT 1.0.main.7b8f5491
  • Plugin Type: Standalone!
  • Bitness: AMD 64-bit Linux GCC 11

Reproduction Steps:
Try to load one of my patches that shipped in 1.8 from my user folder.

Expected Behavior:
The patch loads as normal.

Screenshots:
err box
@selenologist selenologist added the Bug Report Item submitted using the Bug Report template label Jun 11, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone Jun 11, 2021
@baconpaul
Copy link
Collaborator

FYI both the patch and category name need to collide for this to occur.

@baconpaul
Copy link
Collaborator

So even worse
if you quit XT with your user area one selected
then restart
you get your user area one shown
and the checkmark in the factory area

we need a more fulsome resolution but that requires us to put information into the patch. So fixing this one is actually tricky. Gotta ponder the right approach.

baconpaul added a commit to baconpaul/surge that referenced this issue Aug 23, 2021
@baconpaul
Select patch check mark more reliably
b9c95a1 
If you have an identical category and patch name betwene
the user and factory everything works except the check mark.
With this change it works even more reliably with only one
unfixable case still off (that is, if you save a session with
the factory patch selected on restore it will think you are on the
user patch with the checkmark, even though the patch is fine).

Supress the error message now thigns are better

Closes surge-synthesizer#4668
@baconpaul baconpaul mentioned this issue Aug 23, 2021
Merged
baconpaul added a commit that referenced this issue Aug 23, 2021
@baconpaul
Select patch check mark more reliably (#4897)
ef72541 
If you have an identical category and patch name betwene
the user and factory everything works except the check mark.
With this change it works even more reliably with only one
unfixable case still off (that is, if you save a session with
the factory patch selected on restore it will think you are on the
user patch with the checkmark, even though the patch is fine).

Supress the error message now thigns are better

Closes #4668
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Patch Browser
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Select patch check mark more reliably baconpaul/surge
3 participants
@mkruselj @baconpaul @selenologist