Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes XT can hit this assertion #4629

Closed
baconpaul opened this issue Jun 1, 2021 · 1 comment
Closed

Sometimes XT can hit this assertion #4629

baconpaul opened this issue Jun 1, 2021 · 1 comment
Labels
Bug Report Item submitted using the Bug Report template
Milestone

Comments

@baconpaul
Copy link
Collaborator

One of my code paths is doing an end without a begin. Debug before we ship.

   #if JUCE_DEBUG && ! JUCE_DISABLE_AUDIOPROCESSOR_BEGIN_END_GESTURE_CHECKING
    // This means you've called endChangeGesture without having previously
    // called beginChangeGesture. That might be fine in most hosts, but it
    // would be better to keep the calls matched correctly.
    jassert (isPerformingGesture);
    isPerformingGesture = false;
   #endif
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label Jun 1, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Jun 1, 2021
@baconpaul
Copy link
Collaborator Author

I will leave this open but one case was

select slider
drag
rmb

and i have fixed that case in an upcoming branch (where the RMB didn't set type to no edit)

close this if i don't find others over the next month.

baconpaul added a commit to baconpaul/surge that referenced this issue Jun 3, 2021
1. Start splitting SGE into more bite sized program units
2. Re-implement the logic for when to hide and show the infowindow
   and delegate it to the widgets. This also fixes many things.

Closes surge-synthesizer#4595
Addresses surge-synthesizer#4629
baconpaul added a commit to baconpaul/surge that referenced this issue Jun 3, 2021
1. Start splitting SGE into more bite sized program units
2. Re-implement the logic for when to hide and show the infowindow
   and delegate it to the widgets. This also fixes many things.

Closes surge-synthesizer#4595
Addresses surge-synthesizer#4629
baconpaul added a commit that referenced this issue Jun 3, 2021
1. Start splitting SGE into more bite sized program units
2. Re-implement the logic for when to hide and show the infowindow
   and delegate it to the widgets. This also fixes many things.

Closes #4595
Addresses #4629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template
Projects
None yet
Development

No branches or pull requests

1 participant