Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone (and maybe plugins) selects wrong patch name on load #4625

Closed
baconpaul opened this issue May 31, 2021 · 1 comment · Fixed by #4635
Closed

Standalone (and maybe plugins) selects wrong patch name on load #4625

baconpaul opened this issue May 31, 2021 · 1 comment · Fixed by #4635
Labels
Bug Report Item submitted using the Bug Report template
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

  1. Launch standalone
  2. Options / Reset to Default State (get Init Saw)
  3. Load a patch (I chose Jacky / Mallets / Cymbell 1)
  4. Quit Standalone
  5. Restart Standalone

At this point the sound is Cymbell 1
But the checkmark selected patch is "Init Saw"
@baconpaul baconpaul added the Bug Report Item submitted using the Bug Report template label May 31, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone May 31, 2021
@baconpaul
Copy link
Collaborator Author

OK the reason for this is patchid used to be -1 so the patchid < 0 in the load is .. well. That's off. Lemme see if I can fix it.

baconpaul added a commit to baconpaul/surge that referenced this issue Jun 3, 2021
@baconpaul
Restore patchid on initial load
5ca6680 
The initial load would ignore the patchid-from-name
guess since we had already found Init Saw. Make it so
we beleive the name with various checks to make sure
that is reasonable. Closes surge-synthesizer#4625.

Also puts the inti patch name and template as a member of
storage and uses that consistently, which is part of the
way to surge-synthesizer#4502.
@baconpaul baconpaul mentioned this issue Jun 3, 2021
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Jun 3, 2021
@baconpaul
Restore patchid on initial load
42af31d 
The initial load would ignore the patchid-from-name
guess since we had already found Init Saw. Make it so
we beleive the name with various checks to make sure
that is reasonable. Closes surge-synthesizer#4625.

Also puts the inti patch name and template as a member of
storage and uses that consistently, and allows a user default
for the patch to use there.  Closes surge-synthesizer#4502.
baconpaul added a commit that referenced this issue Jun 3, 2021
@baconpaul
Restore patchid on initial load (#4635)
2799db3 
The initial load would ignore the patchid-from-name
guess since we had already found Init Saw. Make it so
we beleive the name with various checks to make sure
that is reasonable. Closes #4625.

Also puts the inti patch name and template as a member of
storage and uses that consistently, and allows a user default
for the patch to use there.  Closes #4502.
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Restore patchid on initial load baconpaul/surge
1 participant
@baconpaul