Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add component type aliases to the skin engine #4618

Closed
baconpaul opened this issue May 30, 2021 · 1 comment · Fixed by #4746
Closed

Add component type aliases to the skin engine #4618

baconpaul opened this issue May 30, 2021 · 1 comment · Fixed by #4746
Labels
Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE Skinning Engine Issues related to Surge's skin engine
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

The only place that "CSurgeSlider" et al live in the codebase now is as the skin literals for ultimateparentclass which drive the skin engine. We need to preserve these literals (skins may use them as class names) but should add better ones which match the JUCE classes and resolve them as aliases at skin load time, basically.
@baconpaul baconpaul added Skinning Engine Issues related to Surge's skin engine Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE labels May 30, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone May 30, 2021
@baconpaul
Copy link
Collaborator Author

sigh a bunch of version1 / version2 stuff here

baconpaul added a commit to baconpaul/surge that referenced this issue Jul 13, 2021
@baconpaul
Base Class Aliases in the Skin Engine
fd01f10 
The ultimateparentclass had a name like "CSurgeSlider" which
we need to keep so skins work but we also want aliases. So

1. Add a .withAlias to Component
2. use it in SkinModel
3. Resolve it in SkinSupport
4. Change SGE to compare defaultComponent with the object as
   opposed to UPC with the string

Closes surge-synthesizer#4618
@baconpaul baconpaul mentioned this issue Jul 13, 2021
Merged
baconpaul added a commit that referenced this issue Jul 13, 2021
@baconpaul
Base Class Aliases in the Skin Engine (#4746)
f6b52d1 
The ultimateparentclass had a name like "CSurgeSlider" which
we need to keep so skins work but we also want aliases. So

1. Add a .withAlias to Component
2. use it in SkinModel
3. Resolve it in SkinSupport
4. Change SGE to compare defaultComponent with the object as
   opposed to UPC with the string

Closes #4618
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE Skinning Engine Issues related to Surge's skin engine
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Base Class Aliases in the Skin Engine baconpaul/surge
1 participant
@baconpaul