Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the SGE JUCE unique pointers on skin change #4588

Closed
baconpaul opened this issue May 23, 2021 · 0 comments · Fixed by #4850
Closed

Clean up the SGE JUCE unique pointers on skin change #4588

baconpaul opened this issue May 23, 2021 · 0 comments · Fixed by #4850
Labels
Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

This is a wierdo technical issue that @baconpaul needs to remember to deal with soon enough and this is just a placeholder for him to remember.
@baconpaul baconpaul added the Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE label May 23, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone May 23, 2021
@mkruselj mkruselj changed the title Clean up the SGE Juce Unique Ptrs on Skin Change Clean up the SGE JUCE unique pointers on skin change May 23, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Aug 17, 2021
@baconpaul
Remove prior skin components on skin swap
9fc0088 
Prior skin components were removed from frame but
a refernece to their pointer was still around. When
we swap skins, clean them up. (They didn't leak per
se since they went away at shutdown but they were unused
and unallocated at runtime before this)

Closes surge-synthesizer#4588
@baconpaul baconpaul mentioned this issue Aug 17, 2021
Merged
baconpaul added a commit that referenced this issue Aug 17, 2021
@baconpaul
Remove prior skin components on skin swap (#4850)
8b9b651 
Prior skin components were removed from frame but
a refernece to their pointer was still around. When
we swap skins, clean them up. (They didn't leak per
se since they went away at shutdown but they were unused
and unallocated at runtime before this)

Closes #4588
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Remove prior skin components on skin swap baconpaul/surge
1 participant
@baconpaul