Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JUCEifying the widgets; Clean up bugs afterwards #4587

Closed
baconpaul opened this issue May 23, 2021 · 4 comments
Closed

JUCEifying the widgets; Clean up bugs afterwards #4587

baconpaul opened this issue May 23, 2021 · 4 comments
Labels
Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented May 23, 2021 •
edited
Loading

Keep this here for bugs
@baconpaul baconpaul added the Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE label May 23, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone May 23, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue May 23, 2021
@baconpaul
Remove CEffectLabel; Introduce Surge::Widgets::EffectLabel
395c432 
Addresses surge-synthesizer#4587
@baconpaul baconpaul mentioned this issue May 23, 2021
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue May 23, 2021
@baconpaul
Remove CEffectLabel; Introduce Surge::Widgets::EffectLabel
fd36a1e 
Addresses surge-synthesizer#4587
baconpaul added a commit that referenced this issue May 23, 2021
@baconpaul
Remove CEffectLabel; Introduce Surge::Widgets::EffectLabel (#4589)
3df7337 
Addresses #4587
@mkruselj mkruselj changed the title Jucifyin the Widgets JUCEifying the widgets May 23, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue May 23, 2021
@baconpaul
ReWrite the Vumeter as 100% Juce code
dacc91c 
Fixes all the drawing bugs; manages the memory better;
etc... Also fix a bug with effect labels not being removed,
add another API point or to in escape while we port,
and a few other tiny fixes

Addresses surge-synthesizer#4587
Closes surge-synthesizer#4348
@baconpaul baconpaul mentioned this issue May 23, 2021
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue May 23, 2021
@baconpaul
ReWrite the Vumeter as 100% Juce code
16c41da 
Fixes all the drawing bugs; manages the memory better;
etc... Also fix a bug with effect labels not being removed,
add another API point or to in escape while we port,
and a few other tiny fixes

Addresses surge-synthesizer#4587
Closes surge-synthesizer#4348
baconpaul added a commit that referenced this issue May 23, 2021
@baconpaul
ReWrite the Vumeter as 100% Juce code (#4590)
1f2f075 
Fixes all the drawing bugs; manages the memory better;
etc... Also fix a bug with effect labels not being removed,
add another API point or to in escape while we port,
and a few other tiny fixes

Addresses #4587
Closes #4348
baconpaul added a commit to baconpaul/surge that referenced this issue May 24, 2021
@baconpaul
CHSwitch2 to Surge::Widgets::MultiSwitch
945f21f 
The inexorable push to rewrite the lot of it in JUCE takes a big
step forward as the widely used CHSwitch2 becomes a pure juce
widget.

As I went I contnue to add helpers and commonly used APIs I need.
In this case, a wheel accumulation helper and also an API
on skin to get the full hover bundle set.

Addresses surge-synthesizer#4587
@baconpaul baconpaul mentioned this issue May 24, 2021
Merged
baconpaul added a commit that referenced this issue May 24, 2021
@baconpaul
CHSwitch2 to Surge::Widgets::MultiSwitch (#4592)
82d4074 
The inexorable push to rewrite the lot of it in JUCE takes a big
step forward as the widely used CHSwitch2 becomes a pure juce
widget.

As I went I contnue to add helpers and commonly used APIs I need.
In this case, a wheel accumulation helper and also an API
on skin to get the full hover bundle set.

Addresses #4587
baconpaul added a commit to baconpaul/surge that referenced this issue May 25, 2021
@baconpaul
Move CAboutBox to Surge::Widgets::AboutScreen
a16cbb9 
Not complete yet. Need to do images and hperlinks. But lets me
keep shrinking that footprint so lets merge here and return to it
later in the week. At least we have copy and paste working!

Closes surge-synthesizer#4382
Addresses surge-synthesizer#4587
@baconpaul baconpaul mentioned this issue May 25, 2021
Merged
baconpaul added a commit that referenced this issue May 25, 2021
@baconpaul
Move CAboutBox to Surge::Widgets::AboutScreen (#4606)
d0309d3 
Not complete yet. Need to do images and hperlinks. But lets me
keep shrinking that footprint so lets merge here and return to it
later in the week. At least we have copy and paste working!

Closes #4382
Addresses #4587
baconpaul added a commit to baconpaul/surge that referenced this issue May 25, 2021
@baconpaul
CMidiLearnOverlay -> juce::Drawable
153f958 
Don't even need a class for this one!
Addresses surge-synthesizer#4587
This was referenced May 25, 2021
Merged
Closed
baconpaul added a commit that referenced this issue May 25, 2021
@baconpaul
CMidiLearnOverlay -> juce::Drawable (#4610)
efb0155 
Don't even need a class for this one!
Addresses #4587
@baconpaul baconpaul mentioned this issue May 29, 2021
Closed
@baconpaul baconpaul changed the title JUCEifying the widgets JUCEifying the widgets; Clean up bugs afterwards Jun 1, 2021
@baconpaul
Copy link
Collaborator Author

baconpaul commented Jun 1, 2021 •
edited
Loading

Slider

Screen Shot 2021-06-01 at 8 31 19 AM

Handle is clipped too aggressively in the slider

@baconpaul
Copy link
Collaborator Author

CMenuAsSlider

  • Glyph Placement
  • Non resource images

@baconpaul
Copy link
Collaborator Author

baconpaul commented Jun 27, 2021 •
edited
Loading

~

@baconpaul
Copy link
Collaborator Author

Closing and moving the one thing left to #4737

@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE
Projects
None yet
Milestone
Surge XT 1.0
Development

No branches or pull requests
1 participant
@baconpaul