Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-activate the LastChance mechanism #4585

Closed
baconpaul opened this issue May 23, 2021 · 0 comments · Fixed by #4686
Closed

Re-activate the LastChance mechanism #4585

baconpaul opened this issue May 23, 2021 · 0 comments · Fixed by #4686
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

The VSTGUI coded last chance mechanism which made the popup popup from anywhere was done in a way which didn't work with juce native widgets so when i merged #4584 I turned it off for a bit. This issue is to remind me to turn it back on the right way soon.
@baconpaul baconpaul added UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc. Bug Report Item submitted using the Bug Report template labels May 23, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone May 23, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Jun 27, 2021
@baconpaul
Move CFrame -> Surge::Widgets::MainFrame (most of the way)
7657574 
1. Move CFrame -> Surge::Widgets::MainFrame
2. Remove all of CView from escape
3. Restore the last chance mechanism (closes surge-synthesizer#4585)

Still todo: Those deprecated where / menu position functions
need fixing.
@baconpaul baconpaul mentioned this issue Jun 27, 2021
Merged
baconpaul added a commit that referenced this issue Jun 27, 2021
@baconpaul
Move CFrame -> Surge::Widgets::MainFrame (most of the way) (#4686)
1998768 
1. Move CFrame -> Surge::Widgets::MainFrame
2. Remove all of CView from escape
3. Restore the last chance mechanism (closes #4585)

Still todo: Those deprecated where / menu position functions
need fixing.
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template UX Issues related to user experience (UX) - mouse, touch, keyboard, MIDI inputs, etc.
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Move CFrame -> Surge::Widgets::MainFrame (most of the way) baconpaul/surge
1 participant
@baconpaul