Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distortion DC blowup when toggling on/off #4565

Closed
KosmiKFead opened this issue May 19, 2021 · 1 comment · Fixed by #4753
Closed

Distortion DC blowup when toggling on/off #4565

KosmiKFead opened this issue May 19, 2021 · 1 comment · Fixed by #4753
Labels
Bug Report Item submitted using the Bug Report template Effects
Milestone

Comments

@KosmiKFead
Copy link

PRESETS.zip

Distortion FX blows up (extreme DC offset) when switching it on

Surge Version
1.9.0
vst3
64bit

Steps to reproduce the behavior:

  1. Open "Neuro Grease" Preset
  2. Turn dist FX on
  3. Blow Up!

To recover switch off the dist FX and also the send FX freq Shifter

Expected Distortion to switch on and distort the audio. After distortion failed i expected audio to pop back on when it is again switched off.

Computer Information (please complete the following information):

  • Win7 64bit
  • FL Studio 20.8.3
@KosmiKFead KosmiKFead added the Bug Report Item submitted using the Bug Report template label May 19, 2021
@mkruselj mkruselj added this to the Surge XT 1.0 milestone May 19, 2021
@mkruselj mkruselj changed the title Distortion DC Blowup on When enable or disable Dist FX Distortion DC blowup when toggling on/off Jul 6, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 15, 2021
Drive == 0 in distortion at init; with the SSE shapers
that blows you out to nan. Init drive to a reasonable
value.

Closes surge-synthesizer#4565
@baconpaul
Copy link
Collaborator

This was a remarkably useful bug report, thank you. Sorry it took us a couple of months to get to it

I've merged a fix which will be in our next release. The problem is with the two SSE-based wave shapers (Sine and Digi) in distortion. If you take your patch with 1.9 and change the wave shaper to hard or soft instead then you should avoid the blowup in the 1.9 vintage.

baconpaul added a commit that referenced this issue Jul 15, 2021
Drive == 0 in distortion at init; with the SSE shapers
that blows you out to nan. Init drive to a reasonable
value.

Closes #4565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Item submitted using the Bug Report template Effects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants