Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menus don't invalidate their components #4487

Closed
baconpaul opened this issue May 4, 2021 · 2 comments · Fixed by #4720
Closed

Menus don't invalidate their components #4487

baconpaul opened this issue May 4, 2021 · 2 comments · Fixed by #4720
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

some do but not all
i fixed one of these (filter reset to default) but do a filter set to keytrack and see that you need to force a repaint
@baconpaul baconpaul added Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE labels May 4, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone May 4, 2021
@mkruselj mkruselj changed the title menus don't invalidate their components Menus don't invalidate their components May 6, 2021
@baconpaul
Copy link
Collaborator Author

baconpaul commented May 17, 2021 •
edited by mkruselj
Loading

I bet if we just add

https://docs.juce.com/master/classComponent.html#a7845e402a21d2b86d8c4ec48bc7c93b1

to a low enough point set to true we will be 100% of the way there. Probably something like where the CControl sets its juce buddy in efvg

@mkruselj
Copy link
Collaborator

Man, JUCE is just superbly thought out software...

baconpaul added a commit to baconpaul/surge that referenced this issue Jul 5, 2021
@baconpaul
Add an endHover explicit method and call it
6c29a18 
This results in popup menus calling endHover at selection and
thus making the menu-at-hover go away if we implement endHover
on all our components prolerly which I think I have

Closes surge-synthesizer#4487
@baconpaul baconpaul mentioned this issue Jul 5, 2021
Merged
baconpaul added a commit that referenced this issue Jul 6, 2021
@baconpaul
Add an endHover explicit method and call it (#4720)
811fae7 
This results in popup menus calling endHover at selection and
thus making the menu-at-hover go away if we implement endHover
on all our components prolerly which I think I have

Closes #4487
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Report Item submitted using the Bug Report template Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Add an endHover explicit method and call it baconpaul/surge
2 participants
@mkruselj @baconpaul