Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensemble modifies signal at 100% dry #4463

Closed
baconpaul opened this issue May 2, 2021 · 1 comment · Fixed by #4467
Closed

Ensemble modifies signal at 100% dry #4463

baconpaul opened this issue May 2, 2021 · 1 comment · Fixed by #4467
Labels
DSP Issues and feature requests related to sound generation in the synth Effects
Milestone

Comments

@baconpaul
Copy link
Collaborator

Ensemble at 100% dry still modifies signal

problem seems to be where we do

 // reduce input by 3 dB
            dataL[s] *= 0.75f;
            dataR[s] *= 0.75f;

            // soft-clip input
            dataL[s] = lookup_waveshape(wst_soft, dataL[s] + fbStateL);
            dataR[s] = lookup_waveshape(wst_soft, dataR[s] + fbStateR);

which seems like it should probably be a copy (so wsDataL[s] = 0.75 * dataL[s]) to leave dataL unchanged for the final mix.

@baconpaul baconpaul added DSP Issues and feature requests related to sound generation in the synth Effects labels May 2, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone May 2, 2021
@mkruselj
Copy link
Collaborator

mkruselj commented May 3, 2021

This one is on me, I should have been more careful. Fix incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DSP Issues and feature requests related to sound generation in the synth Effects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants