We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensemble at 100% dry still modifies signal
problem seems to be where we do
// reduce input by 3 dB dataL[s] *= 0.75f; dataR[s] *= 0.75f; // soft-clip input dataL[s] = lookup_waveshape(wst_soft, dataL[s] + fbStateL); dataR[s] = lookup_waveshape(wst_soft, dataR[s] + fbStateR);
which seems like it should probably be a copy (so wsDataL[s] = 0.75 * dataL[s]) to leave dataL unchanged for the final mix.
The text was updated successfully, but these errors were encountered:
This one is on me, I should have been more careful. Fix incoming.
Sorry, something went wrong.
Fix gain and clipping math being done on dry signal in Ensemble (#4467)
9131e31
* Fix gain and clipping math being done on dry signal in Ensemble Closes #4463
Successfully merging a pull request may close this issue.
Ensemble at 100% dry still modifies signal
problem seems to be where we do
which seems like it should probably be a copy (so wsDataL[s] = 0.75 * dataL[s]) to leave dataL unchanged for the final mix.
The text was updated successfully, but these errors were encountered: