Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Units we can Remove/Rewrite now we have JUCE #4337

Closed
4 tasks done
baconpaul opened this issue Apr 21, 2021 · 1 comment
Closed
4 tasks done

Code Units we can Remove/Rewrite now we have JUCE #4337

baconpaul opened this issue Apr 21, 2021 · 1 comment
Labels
Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Apr 21, 2021 •
edited
Loading

  • DisplayInfo bites the dust
  • Mostly delete CScalableBitmap
  • UserInteractions to pointer vs compile time with all that code removed
  • Most of what ends up left over in src/win etc...
@baconpaul baconpaul added the Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE label Apr 21, 2021
@baconpaul baconpaul added this to the Surge XT 1.0 milestone Apr 21, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Apr 21, 2021
@baconpaul
Remove DisplayInfo; move to juce::Desktop API
0dfb344 
Also remove all the non-JUCE CScalableBitmap code

Addresses surge-synthesizer#4337
@baconpaul baconpaul mentioned this issue Apr 21, 2021
Merged
baconpaul added a commit that referenced this issue Apr 21, 2021
@baconpaul
Remove DisplayInfo; move to juce::Desktop API (#4344)
dd594aa 
Also remove all the non-JUCE CScalableBitmap code

Addresses #4337
@mkruselj mkruselj changed the title Code Units we can Remove/Rewrite now we have Juce Code Units we can Remove/Rewrite now we have JUCE Apr 21, 2021
@baconpaul
Copy link
Collaborator Author

An important test for UserInteractinos being factored properly

if you

export PIPELINE_OVERRIDE_DATA_HOME=`pwd`/resources/dataXXX

and build the LV2 it never starts a UI; so we should not open a dialog box. But now it does because I initialize user stuff at the wrong point in the process.

baconpaul added a commit to baconpaul/surge that referenced this issue Apr 23, 2021
@baconpaul
UserInteractions Refactoring
10b0fcc 
Addresses surge-synthesizer#4337
Closes surge-synthesizer#2671 surge-synthesizer#3435

Refactor/Remove the UserInteractions in favor of JUCE equivalents
and appropirate wrappers

- openURL -> juce::URL.lauch
- showHTML -> surgeguieditor builtin
- Remove openFileInFinder or whatnot for juce::URL(juce::File()).laucnh
- promptInfo removed; single use replaced with an Alert box
- Remove UserInteractions::promptError to be data driven
- promptOKCancel moved to a gui free function which can be replaced and
  is replaced in SGE
- promptFileOpen replaced with juce::FileChooser
- Finally, remove the old files which were no longer used
@baconpaul baconpaul mentioned this issue Apr 23, 2021
Merged
baconpaul added a commit that referenced this issue Apr 23, 2021
@baconpaul
UserInteractions Refactoring (#4379)
4ca0fa8 
Addresses #4337
Closes #2671 #3435

Refactor/Remove the UserInteractions in favor of JUCE equivalents
and appropirate wrappers

- openURL -> juce::URL.lauch
- showHTML -> surgeguieditor builtin
- Remove openFileInFinder or whatnot for juce::URL(juce::File()).laucnh
- promptInfo removed; single use replaced with an Alert box
- Remove UserInteractions::promptError to be data driven
- promptOKCancel moved to a gui free function which can be replaced and
  is replaced in SGE
- promptFileOpen replaced with juce::FileChooser
- Finally, remove the old files which were no longer used
baconpaul added a commit to baconpaul/surge that referenced this issue Apr 23, 2021
@baconpaul
Remove the prior-version OS specific files
296b440 
No longer needed in XT.

Closes surge-synthesizer#4337
@baconpaul baconpaul mentioned this issue Apr 23, 2021
Merged
baconpaul added a commit to baconpaul/surge that referenced this issue Apr 23, 2021
@baconpaul
Remove the prior-version OS specific files
782ebc8 
No longer needed in XT.

Closes surge-synthesizer#4337
baconpaul added a commit to baconpaul/surge that referenced this issue Apr 23, 2021
@baconpaul
Remove the prior-version OS specific files
33aea49 
No longer needed in XT.

Closes surge-synthesizer#4337
baconpaul added a commit to baconpaul/surge that referenced this issue Apr 23, 2021
@baconpaul
Remove the prior-version OS specific files
8db7faf 
No longer needed in XT.

Closes surge-synthesizer#4337
mkruselj pushed a commit that referenced this issue Apr 23, 2021
@baconpaul
Remove the prior-version OS specific files (#4380)
f471490 
No longer needed in XT.

Closes #4337
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Rebuild With JUCE Issues pertaining to porting Surge from VSTGUI to JUCE
Projects
None yet
Milestone
Surge XT 1.0
Development

No branches or pull requests
1 participant
@baconpaul