Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Init-Highpass setting to "zero" instead of 50hz #414

Closed
esaruoho opened this issue Jan 30, 2019 · 2 comments
Closed

Set Init-Highpass setting to "zero" instead of 50hz #414

esaruoho opened this issue Jan 30, 2019 · 2 comments
Labels
Feature Request New feature request

Comments

@esaruoho
Copy link
Collaborator

Currently the Highpass setting in Surge is 50Hz.

Proposal: Set the Highpass to minimum the slider will go (which is something like 6Hz).

The parameter in question is here:
vember_audio__surge__ 64bit__and_renoise__intel_64bit_
@esaruoho esaruoho added Feature Request New feature request help wanted labels Jan 30, 2019
@baconpaul
Copy link
Collaborator

SurgePatch.cpp has a method called init patch or some such which sets the in memory default init patch.

@esaruoho
Copy link
Collaborator Author

starting at line 539 there's a void SurgePatch::init_default_values()
which lists a ton of parameters, none of which are HP though. interesting.

hmm.. unless if scene[sc].lowcut.val.f = -36; // scene[sc].lowcut.val_min.f; is it.

esaruoho added a commit that referenced this issue Jan 30, 2019
@esaruoho
Set Init patch HP to lowest frequency (6.875Hz)
3f1726d 
Fixes #414 

This changes the Generic HighPass Filter (that is applied whether F1 or F2 are on or off) from 50Hz to minimum, which is 6.875Hz.
@esaruoho esaruoho mentioned this issue Jan 30, 2019
Merged
baconpaul pushed a commit to baconpaul/surge that referenced this issue Jul 10, 2019
@esaruoho
Set Init patch HP to lowest frequency (6.875Hz)
ac7c317 
Fixes surge-synthesizer#414 

This changes the Generic HighPass Filter (that is applied whether F1 or F2 are on or off) from 50Hz to minimum, which is 6.875Hz.

Former-commit-id: 9da8efdc2991a5c88892623612c2712668f7df97 [formerly 3f1726d]
Former-commit-id: 1418e83d6c3a4f50dd5eb6ef8c7491dcb53c5328
Former-commit-id: 71eb0adb65ca401c5413f1a5dade6a3af565727e
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request New feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@esaruoho @baconpaul