Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XT Native Tuning Improvements #4046

Closed
2 tasks done
baconpaul opened this issue Mar 9, 2021 · 0 comments · Fixed by #4710
Closed
2 tasks done

XT Native Tuning Improvements #4046

baconpaul opened this issue Mar 9, 2021 · 0 comments · Fixed by #4710
Labels
Tuning Non-standard tuning extensions
Milestone
Surge XT 1.0

Comments

@baconpaul
Copy link
Collaborator

baconpaul commented Mar 9, 2021 •
edited
Loading

  • The MTS mode skips the note when a KBM is indicating. Can we make native mode do the same?
  • with a non uniform KBM the surge pitches are correct but the HTML display is incorrect. The HTML display probably loops over the scale not the tuning or some such is my guess.
@baconpaul baconpaul added the Tuning Non-standard tuning extensions label Mar 9, 2021
@baconpaul baconpaul changed the title KBM Note Skip in Native KBM mode improved XT Native Tuning Improvements May 23, 2021
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 1, 2021
@baconpaul
Greatly improve unmapped note handling in Surge
cfaa0ad 
1. Unmapped notes with native tunings now don't sound as opposed
   to sounding a constant frequency
2. Pitch bends across unmapped notes now do something reasonable

This brings our native mode in line with oddsound-mts for skipped note
handling

Address surge-synthesizer#4046
@baconpaul baconpaul mentioned this issue Jul 1, 2021
Merged
baconpaul added a commit that referenced this issue Jul 1, 2021
@baconpaul
Greatly improve unmapped note handling in Surge (#4703)
a75f5d2 
1. Unmapped notes with native tunings now don't sound as opposed
   to sounding a constant frequency
2. Pitch bends across unmapped notes now do something reasonable

This brings our native mode in line with oddsound-mts for skipped note
handling

Address #4046
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 3, 2021
@baconpaul
Correct Tuning HTML
c3b4783 
Tuning HTML in presence of non-monotonic KBM was wrong because
we were still using an ancient ancient API. Fix it all up.

CLoses surge-synthesizer#4046
baconpaul added a commit to baconpaul/surge that referenced this issue Jul 3, 2021
@baconpaul
Correct Tuning HTML
944276f 
Tuning HTML in presence of non-monotonic KBM was wrong because
we were still using an ancient ancient API. Fix it all up.

CLoses surge-synthesizer#4046
@baconpaul baconpaul mentioned this issue Jul 3, 2021
Merged
baconpaul added a commit that referenced this issue Jul 3, 2021
@baconpaul
Correct Tuning HTML (#4710)
9c91ffa 
Tuning HTML in presence of non-monotonic KBM was wrong because
we were still using an ancient ancient API. Fix it all up.

CLoses #4046
@bobobo199733 bobobo199733 mentioned this issue Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tuning Non-standard tuning extensions
Projects
None yet
Milestone
Surge XT 1.0
Development

Successfully merging a pull request may close this issue.

Correct Tuning HTML baconpaul/surge
1 participant
@baconpaul